Skip to content

Cleanup, add PHP file support #164

Cleanup, add PHP file support

Cleanup, add PHP file support #164

Triggered via pull request May 16, 2024 11:44
@swissspidyswissspidy
synchronize #270
cleanup
Status Failure
Total duration 26s
Artifacts

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 11 warnings
Lint: inc/WebhookHandler.php#L23
Incorrect order of annotations groups.
Lint: inc/WebhookHandlerFactory.php#L24
There must be a single blank line after a tag group
Lint: inc/WebhookHandlerFactory.php#L27
Expected 1 line between annotations groups, found 2.
Lint: inc/CLI/InfoCommand.php#L152
Function is_string() should be referenced via a fully qualified name.
Lint: tests/phpunit/tests/RestrictedSiteAccess.php#L5
Use of annotation @Package is forbidden.
Lint: tests/phpunit/tests/RestrictedSiteAccess.php#L16
Missing doc comment for function test_does_not_change_restriction_by_default()
Lint: tests/phpunit/tests/RestrictedSiteAccess.php#L28
Missing doc comment for function test_lifts_restriction_for_gp_translations_api_route()
Lint: tests/phpunit/tests/RestrictedSiteAccess.php#L40
Missing doc comment for function test_does_not_change_restriction_for_other_gp_api_route()
Lint: tests/phpunit/tests/RestrictedSiteAccess.php#L52
Missing doc comment for function test_lifts_restriction_for_incoming_webhook_rest_route()
Lint: tests/phpunit/tests/RestrictedSiteAccess.php#L64
Missing doc comment for function test_lifts_restriction_for_legacy_incoming_webhook_rest_rout()
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lint: tests/phpunit/bootstrap.php#L1
A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 54 and the first side effect is on line 8.
Lint: tests/phpunit/bootstrap.php#L28
putenv() found. Changing configuration values at runtime is strongly discouraged.
Lint: tests/phpunit/tests/Updater.php#L105
serialize() found. Serialized data has known vulnerability problems with Object Injection. JSON is generally a better approach for serializing data. See https://www.owasp.org/index.php/PHP_Object_Injection
Lint: tests/phpunit/tests/Updater.php#L110
Unused variable $timestamp.
Lint: tests/phpunit/tests/Updater.php#L122
Unused variable $timestamp.
Lint: tests/phpunit/tests/Updater.php#L136
Unused variable $timestamp.
Lint: tests/phpunit/tests/ZipProvider.php#L315
Equals sign not aligned correctly; expected 1 space but found 2 spaces
Lint: tests/phpunit/tests/ZipProvider.php#L335
Found precision alignment of 2 spaces.
Lint: tests/phpunit/tests/ZipProvider.php#L336
Found precision alignment of 2 spaces.
Lint: tests/phpunit/tests/ZipProvider.php#L337
Found precision alignment of 2 spaces.