Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting github workflows for CodeQL testing #520

Merged
merged 12 commits into from
May 6, 2024
Merged

Adjusting github workflows for CodeQL testing #520

merged 12 commits into from
May 6, 2024

Conversation

RafaelGCPP
Copy link
Contributor

@RafaelGCPP RafaelGCPP commented Mar 6, 2024

  • Updated CodeQL action versions to v3
  • Updated minimum CMake requirement to 3.5
  • Split CodeQL analysis in two files, one for C++ and one for Python, as the "run" step was not being effective in the Python testing

With those modifications, now the code is tested and validated.

@RafaelGCPP
Copy link
Contributor Author

Related to Issue #521

@wb2osz
Copy link
Owner

wb2osz commented Mar 9, 2024

Thank you for these updates.
I've merged them into the dev branch and am awaiting the results.

73,
John WB2OSZ

@wb2osz wb2osz merged commit 69407cc into wb2osz:master May 6, 2024
6 checks passed
@wb2osz
Copy link
Owner

wb2osz commented May 6, 2024

It turns out this needs to be on master branch.
Merged to master branch.

Copy link
Owner

@wb2osz wb2osz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little concerned about bumping up the minimum cmake version because a very old system might not have it. I guess we can decrease it if anyone yells and doesn't have the ability to upgrade.

@RafaelGCPP
Copy link
Contributor Author

Feel free to do so. The bumping in the CMake version was a collateral on my side. My CMake warned about not supporting the older version, so I bumped it up, but it is not a big deal at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants