-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusting github workflows for CodeQL testing #520
Conversation
Related to Issue #521 |
Thank you for these updates. 73, |
It turns out this needs to be on master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned about bumping up the minimum cmake version because a very old system might not have it. I guess we can decrease it if anyone yells and doesn't have the ability to upgrade.
Feel free to do so. The bumping in the CMake version was a collateral on my side. My CMake warned about not supporting the older version, so I bumped it up, but it is not a big deal at all. |
With those modifications, now the code is tested and validated.