Migrate keystore to master #27066
Open
Migrate keystore to master #27066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pereyra-m
force-pushed
the
enhancement/26971-migrate-keystore-tool
branch
2 times, most recently
from
965bb18
to
19679b8
Compare
pereyra-m
force-pushed
the
enhancement/26971-migrate-keystore-tool
branch
from
bfc7565
to
e44a47e
Compare
…d to upgrade feature
pereyra-m
force-pushed
the
enhancement/26971-migrate-keystore-tool
branch
2 times, most recently
from
4b0b74d
to
6a755db
Compare
Coverage reportsThe coverage report can be downloaded from here
🟢 All modules have passed the coverage check |
pereyra-m
commented
Nov 28, 2024
| @@ -189,11 +189,11 @@ jobs: | |||
| local coverage_filtered_file="${{github.workspace}}/${{env.BUILD_PATH}}/coverage_${module}_filtered.info" | |||
|
|
|||
| # Generate the coverage report | |||
| lcov --no-external --capture --initial --directory ${module_build_path} --base-directory ${module_path} --exclude "${module_path}/test/*" --output-file ${coverage_base_file} | |||
| lcov --no-external --capture --initial --directory ${module_build_path} --base-directory ${module_path} --exclude "${module_path}/test/*" --output-file ${coverage_base_file} --ignore-errors unused,mismatch | |||
There was a problem hiding this comment.
I've added this flags to ignore some errors:
- unused: the coverage reports that the keystore test folder exclusion is unused
- mismatch: the GTest macros create a number line difference that causes confusion to
lcov
pereyra-m
force-pushed
the
enhancement/26971-migrate-keystore-tool
branch
from
6a755db
to
2157bda
Compare
Coverage reportsThe coverage report can be downloaded from here
🟢 All modules have passed the coverage check |
pereyra-m
force-pushed
the
enhancement/26971-migrate-keystore-tool
branch
2 times, most recently
from
96c2c86
to
f6e3f90
Compare
pereyra-m
force-pushed
the
enhancement/26971-migrate-keystore-tool
branch
from
f6e3f90
to
7a70871
Compare
Coverage reportsThe coverage report can be downloaded from here
🟢 All modules have passed the coverage check |
Coverage reportsThe coverage report can be downloaded from here
🟢 All modules have passed the coverage check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the
wazuh-keystoreto themasterbranch and adapts it to the project structure. The QA/UT tests and required utils were also migrated.The OpenSSL v3.1.0 was added to vcpkg because it was missing and it was the closest version to the one used at branch v4.10.0.
The
IndexerConnectorclass was updated to read the keystore and the plain text credentials were removed.The SPECS and installer scripts were modified to include the new binary, but the RPM package can't be built due to previous errors.
The folders and binaries permissions were preserved but due to facebook/rocksdb#11503 the internal RocksDB files will have 644 instead of 640.
Until this PR is merged #26908, the
root:wazuhpermissions will be used instead ofwazuh:wazuh.Tests
I've installed a package built from this branch and configured the keystore credentials.
A test event is properly indexed