Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced the loading logo size #373

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Reduced the loading logo size #373

merged 2 commits into from
Oct 24, 2024

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Oct 22, 2024 •
edited
Loading

Description

This pull request reduces the size of the loading logo container 33% of the previous size.

  • Reduced the size of the loading logo container from 150px to 100px (height)

Issues Resolved

wazuh/wazuh-dashboard-plugins#7102

Evidences

image

Test

wd-pr-373

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Ensure the size of the loading logo is 100px of height ⚫ ⚫ ⚫

Details

⚫ Ensure the size of the loading logo is 100px of height

How to test:

  1. Download the branch 4.10.0 of wazuh-security-dashboards-plugin
  2. Ensure/change the path of security plugin defined in the SECURITY_PLUGIN_REPO_PATH of docker/dev.sh file
  3. Run the enviroment with security
cd docker
./dev.sh up security

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Oct 22, 2024
@Desvelao Desvelao linked an issue Oct 22, 2024 that may be closed by this pull request
Change loading logo size wazuh/wazuh-dashboard-plugins#7102
Closed
@Desvelao Desvelao mentioned this pull request Oct 22, 2024
Closed
@Desvelao Desvelao marked this pull request as ready for review October 22, 2024 08:55
yenienserrano
yenienserrano approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@JuanGarriuz
Copy link
Member

Test

image

JuanGarriuz
JuanGarriuz approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Desvelao Desvelao merged commit 77002e4 into 4.10.0 Oct 24, 2024
33 of 37 checks passed
@Desvelao Desvelao deleted the change/7102-reduced-loading-logo-size branch October 24, 2024 07:31
Tostti pushed a commit that referenced this pull request Nov 5, 2024
@Desvelao @Tostti
Reduced the loading logo size (#373)
fd5284a
@asteriscos asteriscos mentioned this pull request Nov 11, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change loading logo size
3 participants
@Desvelao @JuanGarriuz @yenienserrano