Add bump2version #151
Add bump2version #151
Conversation
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 160 160
Branches 19 19
=========================================
Hits 160 160 |
There was a problem hiding this comment.
Thanks for this awesome contribution!
I think there are several different and independent things going on here, and my preference would be to have the high level changes (bump2version and python 3.10) to be made separate from each other.
though these changes seem low risk as-is, I think that there is value in being incremental here so that I can at least better understand the requested changes
| - package-ecosystem: "docker" | ||
| directory: "/docker" | ||
| schedule: | ||
| interval: "daily" | ||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" |
docs/development-guide.md
Outdated
| Merging the pull request will trigger a GitHub Action that will create a new release. The creation of this new | ||
| release will trigger a GitHub Action that will to build a wheel & a source distributions of the package and push them to | ||
| [PyPI][pypi]. |
There was a problem hiding this comment.
You are saying that a github release gets created for us as a result of using the bump command?
Currently, new package version publishes happen when we create a release manually
There was a problem hiding this comment.
Hey Josh - What I mean is, when you run bump service as defined in docker-compose.yaml, the service will create a new branch updating the version in the following files and allow the user to create a PR. This PR when approved and merged will trigger a github-actions as defined here.
Files in which version will be updated:
docs/index.mdsetup.cfg
There was a problem hiding this comment.
awesome, this makes sense. somehow I missed the detect_version_bump.yml during my initial review
This makes sense to me, I revertted all the changes related to python 3.10 and updated the PR description |
There was a problem hiding this comment.
There are still some minor questions to be addressed, but I am more than comfortable with what you have here, so i'll approve.
Thank you so much for this contribution @jashparekh !
Resolves #99 and #14