Add support for webp #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinyzenith
previously approved these changes
Mar 4, 2024
|
CC: @Decodetalkers. Can you ACK this? |
|
Hi can you rebase your patch to our development branch at freeze-feat-andreas? |
|
it is ok, @Shinyzenith |
Change for cli option value web-p -> webp
|
@Shinyzenith I've rebased my branch, at least I think so... |
|
https://github.com/waycrate/wayshot/tree/freeze-feat-andreas he means you need pull request to this branch @Gigas002 |
|
Sorry for inconvenience, changed the target branch. |
Decodetalkers
approved these changes
Mar 13, 2024
|
Documentation needs to be updated |
|
Particularly speaking, the following files need to be updated:
|
|
@Shinyzenith Sorry for late answer. I've update documentation file. |
|
Thank you! |
Shinyzenith
approved these changes
Mar 14, 2024
Signed-off-by: Shinyzenith <[email protected]>
|
Hi, resolved a merge conflict by updating the Cargo.lock |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, adds support for
.webpscreenshots output extension. Shouldn't add any complexity/burden to support, I think.