feat: added --human-time flag #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you want date as well , Please let me know . |
|
Thanks for the pr but I am mostly hesitant about adding new crates to the dependency graph. Is there some other options we can explore / features to disable other parts of introduced crate ( I don't have experience with the crate you are using and hence no knowledge of it either ) I like the feature however and the flag name could probably be better named for being intuitive. Also this needs to be documented if we wish to merge this change. |
|
Can you rebase this on feature freeze andreas branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--human-time flag uses more convenient 24-hour format rather than UNIX_EPOCH seconds when saving image to disk.