Performance Tuning #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on the freezing functionality and along the way I'll use this PR to include some performance improvements.
1. Unneeded resized
image_util::rotate_image_bufferdid 1-2 unneeded resizes. Remove the first one if the transform is a normal (or default) and remove the second if the requested size is the same as the original size.Flamegraph before
Flamegraph after
I noticed a run in release mode going from ~0.24s to ~0.13s. I could use
hyperfinefor a better comparison, but I think the flamegraph speaks for itself.