Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Candidates Vote count #36

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Implementing Candidates Vote count #36

merged 4 commits into from
Nov 22, 2023

Conversation

AlexandreSSJr
Copy link
Collaborator

The following enhancements were added on this Pull Request:

  • Candidates Vote count is now displayed on the Candidates Card
  • Minor fixes to vote control confirmation modal display and vote count reloading
  • Fixes all lint issues that were still pending

Finishes the implementation of #6

image

@AlexandreSSJr AlexandreSSJr added the enhancement New feature or request label Nov 21, 2023
@AlexandreSSJr AlexandreSSJr self-assigned this Nov 21, 2023
rakeden
rakeden approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@rakeden rakeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@rakeden rakeden merged commit b448983 into main Nov 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakeden rakeden rakeden approved these changes

@jaegerfe jaegerfe jaegerfe approved these changes

Assignees

@AlexandreSSJr AlexandreSSJr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreSSJr @jaegerfe @rakeden