Virtual fs refactor #4298
Open
Virtual fs refactor #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/cli/src/commands/run/mod.rs # lib/cli/src/commands/run/wasi.rs # lib/wasix/src/os/console/mod.rs # lib/wasix/src/runners/wasi.rs # lib/wasix/src/runners/wasi_common.rs # lib/wasix/src/runners/wcgi/runner.rs
syrusakbary
commented
Nov 10, 2023
syrusakbary
commented
Nov 13, 2023
| @@ -329,3 +327,209 @@ mod tests { | |||
| assert_eq!(super::read(&fs, "/file.txt").await.unwrap(), b""); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Note: we don't need this
This reverts commit 850dac7.
# Conflicts: # Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clean up the virtual filesystem by using better abstraction strategies.
HostFS::new()(and HostFS having full access to the host filesystem) you will doHostFS::new("/path/in/the/host")to then be able to do all the fs operations coming from that relative dirReimplement UnionFS with a simpler approachRemoved Union<dyn VirtualFile>and<dyn Directory>HasheableReimplement OverlayFSReplace the filesystem in WASIX to use UnionFS for the mount directories and OverlayFS on top of the containerwasmer run xyz --dir=./homewhen running WASI (and allow customizing it via config). Plug it also fromwasmer run .... This will fix Improve how mapdir works (proposal) #4182 and also the weird mounting hack we do in packages to make relative paths absolute/tmpfolder is not writeable in spawned sub processes