-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontpage restyle with new scribbles #283
Conversation
✅ Deploy Preview for dreamy-golick-5f201e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@boomskats taking a look! Just wanted to let you know early that, being a CNCF project, we require signed off commits as a part of the DCO check. https://github.com/wasmCloud/wasmcloud.com/pull/283/checks?check_run_id=21068152936 should give you the easy rebase command to do this, it's just an admonition in the commit with your github ID no GPG required. It also looks like there is a conflict in |
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
This needs cleaning up bigtime Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
fml. Added postcss-preset-env plugin to fix failing CSS minification Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
Signed-off-by: boomskats <[email protected]>
c518536
to
4b9ab17
Compare
Signed-off-by: Nikola Markovic <[email protected]>
Thanks @brooksmtownsend, that should all be fixed up now. If you want any more info on why |
@boomskats this is looking great! Really appreciate the time you put in here. I apologise for not having better documenation/automation around this but it looks like there's a few formatting changes. Could you run git diff --name-only origin/main | grep "js\|ts" | xargs npx prettier -w |
Yeah it's a bit of a monster to eyeball, I didn't quite expect that! Does this give you what you're looking for? wasmcloud.com on frontpage-restyle [$!] via v20.10.0
❯ git diff --name-only --diff-filter=MA main | grep 'js$\|ts$\|css$' | xargs npx prettier -w
docusaurus.config.ts 202ms (unchanged)
src/components/HomepageFeatures/index.js 47ms (unchanged)
src/components/HomepageFeatures/styles.module.css 31ms (unchanged)
src/components/NewsSection/index.js 8ms (unchanged)
src/components/NewsSection/styles.module.css 12ms (unchanged)
src/css/custom.css 11ms (unchanged)
src/pages/index.js 11ms (unchanged)
src/pages/index.module.css 16ms (unchanged)
wasmcloud.com on frontpage-restyle [$!] via v20.10.0 took 2s |
Signed-off-by: boomskats <[email protected]>
c3956a7
to
2736e97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing to me! Leaving the merge to @lachieh once he's happy with formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea why the output says unchanged for all those files, but it looks good now!
Thanks! Let's get it merged!
@boomskats this looks amazing, thank you so much ❤️ |
Had to do a bit of conflict resolution in the rebase locally so I'm going to close this and all these changes will get merged in #286. Thanks, again! |
Feature or Problem
A new look for the front page and a few style tweaks to the docusaurus template
Related Issues
n/a
Release Information
n/a
Consumer Impact
n/a
Testing
npm run build
,npm run serve
, visual check of prod buildUnit Test(s)
n/a
Acceptance or Integration
n/a
Manual Verification
As above,
npm run build
,npm run serve
, visual check of prod build