Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontpage restyle with new scribbles #283

Closed
wants to merge 14 commits into from

Conversation

boomskats
Copy link
Contributor

Feature or Problem

A new look for the front page and a few style tweaks to the docusaurus template

Related Issues

n/a

Release Information

n/a

Consumer Impact

n/a

Testing

npm run build, npm run serve, visual check of prod build

Unit Test(s)

n/a

Acceptance or Integration

n/a

Manual Verification

As above, npm run build, npm run serve, visual check of prod build

@boomskats boomskats requested a review from a team as a code owner January 31, 2024 15:07
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for dreamy-golick-5f201e ready!

Name Link
🔨 Latest commit 2736e97
🔍 Latest deploy log https://app.netlify.com/sites/dreamy-golick-5f201e/deploys/65ba7f3b75233900080d825d
😎 Deploy Preview https://deploy-preview-283--dreamy-golick-5f201e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🟢 up 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (🟢 up 17 from production)
SEO: 86 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@brooksmtownsend
Copy link
Member

@boomskats taking a look! Just wanted to let you know early that, being a CNCF project, we require signed off commits as a part of the DCO check. https://github.com/wasmCloud/wasmcloud.com/pull/283/checks?check_run_id=21068152936 should give you the easy rebase command to do this, it's just an admonition in the commit with your github ID no GPG required.

It also looks like there is a conflict in src/css/custom.css that needs resolution

@boomskats
Copy link
Contributor Author

Thanks @brooksmtownsend, that should all be fixed up now. If you want any more info on why postcss-preset-env have a look at the issue here.

@lachieh
Copy link
Contributor

lachieh commented Jan 31, 2024

@boomskats this is looking great! Really appreciate the time you put in here.

I apologise for not having better documenation/automation around this but it looks like there's a few formatting changes. Could you run prettier -w {filename} on the changed files? It looks like it's only js/ts files. If you're on mac/linux you should be able to run this to do all the files in one go:

git diff --name-only origin/main | grep "js\|ts" | xargs npx prettier -w

@boomskats
Copy link
Contributor Author

@boomskats this is looking great! Really appreciate the time you put in here.

I apologise for not having better documenation/automation around this but it looks like there's a few formatting changes. Could you run prettier -w {filename} on the changed files? It looks like it's only js/ts files. If you're on mac/linux you should be able to run this to do all the files in one go:

git diff --name-only origin/main | grep "js\|ts" | xargs npx prettier -w

Yeah it's a bit of a monster to eyeball, I didn't quite expect that! Does this give you what you're looking for?

 wasmcloud.com on  frontpage-restyle [$!] via  v20.10.0
❯ git diff --name-only --diff-filter=MA main | grep 'js$\|ts$\|css$' | xargs npx prettier -w
docusaurus.config.ts 202ms (unchanged)
src/components/HomepageFeatures/index.js 47ms (unchanged)
src/components/HomepageFeatures/styles.module.css 31ms (unchanged)
src/components/NewsSection/index.js 8ms (unchanged)
src/components/NewsSection/styles.module.css 12ms (unchanged)
src/css/custom.css 11ms (unchanged)
src/pages/index.js 11ms (unchanged)
src/pages/index.module.css 16ms (unchanged)

wasmcloud.com on  frontpage-restyle [$!] via  v20.10.0 took 2s

Copy link
Member

@brooksmtownsend brooksmtownsend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing to me! Leaving the merge to @lachieh once he's happy with formatting

Copy link
Contributor

@lachieh lachieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why the output says unchanged for all those files, but it looks good now!

Thanks! Let's get it merged!

@connorsmith256
Copy link
Contributor

@boomskats this looks amazing, thank you so much ❤️

@lachieh
Copy link
Contributor

lachieh commented Jan 31, 2024

Had to do a bit of conflict resolution in the rebase locally so I'm going to close this and all these changes will get merged in #286.

Thanks, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants