Handle division where normalized_margin numerator and denominator are 0
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi! The change in this PR fixes an issue where the numerator (
margin) and denominator (weights) used to computenormalized_margincould be 0. This is probably most common when computing abaseline_marginestimand, when a unit'sbaseline_demandbaseline_gopare 0, resulting inbaseline_marginandbaseline_weightsbeing 0. I've also added a unit test for this case 🎉 Thanks!Jira Ticket
Test Steps
This test bed command:
python run.py 2022-11-08_USA_G redo --office_id S_precinct --fixed_effects "['county_classification']" --geographic_unit_type precinct --pi_method bootstrap --estimands "['margin']" --features "['baseline_normalized_margin', 'median_household_income', 'percent_bachelor_or_higher']" --end_timestamp "2022-11-09 10:31:27-05:00" --single_state IA