Add trade log capability #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add capability to log trades into a journal file
TheoBrigitte
commented
May 11, 2024
helpers/trade.ts
Outdated
| // Trade sold, compute profit. | ||
| confirmedSell(amountOut: number) { | ||
| this.data.amountOut = amountOut; | ||
| this.data.profit = this.data.amountOut - this.data.amountIn.valueOf(); |
There was a problem hiding this comment.
NOTE: profit computation does not account for fee
account for solana transaction fee
TheoBrigitte
commented
May 16, 2024
| @@ -275,7 +317,20 @@ export class Bot { | |||
| } | |||
| } catch (error) { | |||
| logger.error({ mint: rawAccount.mint.toString(), error }, `Failed to sell token`); | |||
| if (trade) { | |||
| trade.close(0, 0, 'sell_failed'); | |||
| this.balance += trade.profit; | |||
There was a problem hiding this comment.
This is not really needed since we later on call this.updatebalance, but that's paving the way for a future dry run mode implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add capability to log trades into a journal file.
Here is an example of journal log entry
{ "mint": "APW3JozNF2N1rCzN6nbgJNN3fWGS8qLgiY3DVeK6BpzV", "balance": 1.001200061, "amountIn": 0.001, "amountOut": 0.001227753, "profit": 0.00022775300000000003, "profitPercent": 22.7753, "start": "2024-05-11T08:24:22.440Z", "end": "2024-05-11T08:26:12.827Z", "time_to_entry": "0:05", "time_to_exit": "0:05", "status": "closed", "id": 1 }It uses the
LOG_FILENAMEvariable to define the journal file and can be set tononeto disable logging.