Added return types

wapacro · Jul 8, 2021 · 81f70ae · 81f70ae
1 parent c8705bb
commit 81f70ae
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/src/Exceptions/CouldNotGetToken.php b/src/Exceptions/CouldNotGetToken.php
@@ -8,7 +8,7 @@
 
 class CouldNotGetToken extends Exception {
 
-    public static function serviceRespondedWithError(string $code, string $message) {
+    public static function serviceRespondedWithError(string $code, string $message): CouldNotGetToken {
         return new static('Microsoft Identity platform responded with code ' . $code . ': ' . $message);
     }
 

diff --git a/src/Exceptions/CouldNotReachService.php b/src/Exceptions/CouldNotReachService.php
@@ -8,11 +8,11 @@
 
 class CouldNotReachService extends Exception {
 
-    public static function networkError() {
+    public static function networkError(): CouldNotReachService {
         return new static('The server couldn\'t be reached');
     }
 
-    public static function unknownError() {
+    public static function unknownError(): CouldNotReachService {
         return new static('An unknown error occured');
     }
 

diff --git a/src/Exceptions/CouldNotSendMail.php b/src/Exceptions/CouldNotSendMail.php
@@ -8,11 +8,11 @@
 
 class CouldNotSendMail extends Exception {
 
-    public static function invalidConfig() {
+    public static function invalidConfig(): CouldNotSendMail {
         return new static('The mail.php configuration is missing from address, transport, client and/or secret key configuration');
     }
 
-    public static function serviceRespondedWithError(string $code, string $message) {
+    public static function serviceRespondedWithError(string $code, string $message): CouldNotSendMail {
         return new static('Microsoft Graph API responded with code ' . $code . ': ' . $message);
     }
 

diff --git a/src/MsGraphMailTransport.php b/src/MsGraphMailTransport.php
@@ -59,7 +59,7 @@ public function __construct(array $config, ClientInterface $client = null) {
      * @throws CouldNotReachService
      * @throws CouldNotGetToken
      */
-    public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = null) {
+    public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = null): int {
         $this->beforeSendPerformed($message);
         $payload = $this->getPayload($message);
         $url = str_replace('{from}', urlencode($payload['from']['emailAddress']['address']), $this->apiEndpoint);
@@ -90,7 +90,7 @@ public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = nul
      * @param Swift_Mime_SimpleMessage $message
      * @return array
      */
-    protected function getPayload(Swift_Mime_SimpleMessage $message) {
+    protected function getPayload(Swift_Mime_SimpleMessage $message): array {
         $from = $message->getFrom();
         $priority = $message->getPriority();
         $attachments = $message->getChildren();
@@ -118,7 +118,7 @@ protected function getPayload(Swift_Mime_SimpleMessage $message) {
      * @param array|string $recipients
      * @return array
      */
-    protected function toRecipientCollection($recipients) {
+    protected function toRecipientCollection($recipients): array {
         $collection = [];
 
         // If the provided list is empty
@@ -158,7 +158,7 @@ protected function toRecipientCollection($recipients) {
      * @param $attachments
      * @return array
      */
-    protected function toAttachmentCollection($attachments) {
+    protected function toAttachmentCollection($attachments): array {
         $collection = [];
 
         foreach ($attachments as $attachment) {
@@ -187,7 +187,7 @@ protected function toAttachmentCollection($attachments) {
      * @throws CouldNotGetToken
      * @throws CouldNotReachService
      */
-    protected function getHeaders() {
+    protected function getHeaders(): array {
         return [
             'Accept' => 'application/json',
             'Authorization' => 'Bearer ' . $this->getAccessToken(),
@@ -200,7 +200,7 @@ protected function getHeaders() {
      * @throws CouldNotReachService
      * @throws CouldNotGetToken
      */
-    protected function getAccessToken() {
+    protected function getAccessToken(): string {
         try {
             return Cache::remember('mail-msgraph-accesstoken', 45, function () {
                 $url = str_replace('{tenant}', $this->config['tenant'] ?? 'common', $this->tokenEndpoint);