Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler Error] fix build error on macOS platform #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Compiler Error] fix build error on macOS platform #3

wants to merge 1 commit into from

Conversation

ttzztztz
Copy link

@ttzztztz ttzztztz commented Jan 14, 2022 •
edited
Loading

Background

This PR fixes an error when building the program because FALSE is not a keyword in c plus plus and will cause an error when compiling

Screen Shot 2022-01-14 at 20 44 24

My environment

Screen Shot 2022-01-14 at 20 45 36

Test plan

  1. Pass CI
  2. manual check
cmake . && make

we could get the result

Screen Shot 2022-01-14 at 20 43 27

Then we try to run the built product

Screen Shot 2022-01-14 at 20 48 20

Reviewers

@wanlin405 @theIK1

@ttzztztz ttzztztz marked this pull request as ready for review January 14, 2022 12:48
@ttzztztz
Copy link
Author

Fixes the issue #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theIK1 theIK1 theIK1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttzztztz @theIK1