Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port CUDAStream to Go #332

Merged
merged 15 commits into from
Sep 18, 2020
Merged

Port CUDAStream to Go #332

merged 15 commits into from
Sep 18, 2020

Conversation

Yancey1989
Copy link
Collaborator

@Yancey1989 Yancey1989 commented Sep 16, 2020 •
edited
Loading

related #327

@codecov
Copy link

codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #332 into develop will decrease coverage by 0.27%.
The diff coverage is 72.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #332      +/-   ##
===========================================
- Coverage    89.11%   88.84%   -0.28%     
===========================================
  Files           33       34       +1     
  Lines         1443     1461      +18     
===========================================
+ Hits          1286     1298      +12     
- Misses          99      105       +6     
  Partials        58       58
Impacted Files Coverage Δ
cuda.go 54.54% <54.54%> (ø)
tensor.go 92.77% <100.00%> (+0.66%) ⬆️
vision/imageloader/imageloader.go 88.88% <0.00%> (-1.39%) ⬇️

@Yancey1989 Yancey1989 changed the title [WIP]Port CUDAStream in Go Port CUDAStream to Go Sep 17, 2020
wangkuiyi
wangkuiyi reviewed Sep 17, 2020
View reviewed changes
Copy link
Owner

@wangkuiyi wangkuiyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we need to complete this PR with more test cases.

cgotorch/build.sh Outdated Show resolved Hide resolved
@Yancey1989
Copy link
Collaborator Author

It seems that we need to complete this PR with more test cases.

Some code should run on CUDA device, I have tested them on P100.

@Yancey1989 Yancey1989 merged commit 84a41d0 into develop Sep 18, 2020
@Yancey1989 Yancey1989 deleted the port_cuda_api branch September 18, 2020 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@QiJune QiJune Awaiting requested review from QiJune

@shendiaomo shendiaomo Awaiting requested review from shendiaomo

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yancey1989 @wangkuiyi