WIP: Support generator-like data loader as PyTorch/libtorch #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #281 +/- ##
===========================================
- Coverage 79.95% 79.79% -0.17%
===========================================
Files 37 37
Lines 1751 1737 -14
===========================================
- Hits 1400 1386 -14
Misses 270 270
Partials 81 81
Continue to review full report at Codecov.
|
wangkuiyi
reviewed
Sep 1, 2020
| torch.GC() | ||
| e.hasGCed = true | ||
| } | ||
| torch.SetTensorFinalizer(e.data.T) |
There was a problem hiding this comment.
By calling torch.SetTensorFinalizer in Example.Data/Target, could we fix the bug #273 ? @shendiaomo @Yancey1989
There was a problem hiding this comment.
It seems this PR works with the C++ wrappered dataset, #273 using ImageLoader which is Go implementation, it seems this PR can not fix it.
wangkuiyi
reviewed
Sep 2, 2020
| // for batch := range Loader(myDataset) { | ||
| // ... | ||
| // } | ||
| func Loader(dataset Dataset) chan Example { |
There was a problem hiding this comment.
This is a correct direction -- to use Go channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
range forlike PyTorch and the C++ frontend