Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issues around the files and introduced manifest builder #13

Closed
wants to merge 19 commits into from

Conversation

Astisme
Copy link

@Astisme Astisme commented Feb 23, 2024

Fixed issues

On top of this:

  • Removed Save/Add buttons -> it works automatically {which means I win the "disable save button on empty list"}
  • Removed slds styling in "action" as it is useless and would leave you with no choice other than use the sfdc styling even in a page which would not have it by default
  • Updating tabs in setup after save and delete in "action"
  • Highlighting tab when user on that url
  • Ability to open full urls in tabs (if I understood that correctly)
  • Created manifest template and manifest builder, to merge chrome and firefox manifests and creating the correct one on the fly

Ready when you are.
Much love.

@Astisme
Copy link
Author

Astisme commented Feb 29, 2024

Contacted on Linkedin

@walters954 walters954 self-requested a review March 7, 2024 15:51
Copy link
Owner

@walters954 walters954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close this PR break each issue into individual branches/prs

@Astisme Astisme closed this Apr 8, 2024
@Astisme Astisme deleted the why-salesforce branch December 6, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants