-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lists #403
Update lists #403
Conversation
Added basic search (using SQL's |
Hmm. I guess it will provoke some performance issues with huge articles, some maybe limit to title for now. Anyway we'll probably propose a search API soon on the server so it will have to be integrated with it at some point. |
Added an option to reverse sort order. The UI part should probably be improved (as for now it is just a menu item that reads "Change sort order"). Suggestions are welcome.
|
|
is the read to review label still valid atm? |
I removed the async loading from this PR - now it is ready for review. |
Looks good. Will review and eventually build tomorrow. |
I forgot to answer that. It seemed to me that the performance was decent even on old devices, so I left it as is. I considered "powerful" search (being able to search in content) more important than minor performance issues (which don't affect anything but search). Though, anyone is free to improve the feature. |
I tested and it was okay for me so I merged. :) |
Adds "endless scrolling" instead of limited list. Memory may still be an issue.
Use
DiffUtil
to update lists partially.I'm not completely sure about the implementation, so suggestions are welcome.
Also, I think I had an issue with the lists not being updated after actions like "open an article - add it to favorite - go back to lists". I couldn't reproduce it yet. I added logging of warning messages "fragment is null". I'm pretty sure it should either update list or log the warning. I have no idea why the fragments can be null after they were initialized (initially I thought, that it might be related to threading, but only the main thread is supposed to access fragments).Probably fixed with 2630998.Related issues:
Testing needed.