Add installer beta icon. Closes microsoft#677 (microsoft#678)

Closes microsoft#677
waldekmastykarz · Apr 25, 2024 · 2078e19 · 2078e19
1 parent bc2f1ee
commit 2078e19
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
@@ -84,7 +84,12 @@ jobs:
           path: ./dev-proxy-abstractions-${{ github.ref_name }}.zip
       - name: Add installer icon
         if: contains(matrix.architecture, 'win-')
-        run: cp ./media/icon.ico ./${{ env.release }}
+        run: |
+          if ('${{ github.ref_name }}'.Contains('beta')) {
+            cp ./media/icon-beta.ico ./${{ env.release }}
+          } else {
+            cp ./media/icon.ico ./${{ env.release }}
+          }
       - name: Update version in beta installer
         if: contains(matrix.architecture, 'win-') && contains(github.ref_name, '-beta')
         run: |

diff --git a/install-beta.iss b/install-beta.iss
@@ -19,7 +19,7 @@ AppPublisherURL={#MyAppURL}
 AppSupportURL={#MyAppURL}
 AppUpdatesURL={#MyAppURL}
 AppVerName={#MyAppName} v{#MyAppVersion}
-UninstallDisplayIcon={app}\icon.ico
+UninstallDisplayIcon={app}\icon-beta.ico
 DefaultDirName={autopf}\{#MyAppName}
 DefaultGroupName={#MyAppName}
 DisableProgramGroupPage=yes

diff --git a/media/icon-beta.ico b/media/icon-beta.ico
diff --git a/media/icon-beta.png b/media/icon-beta.png
diff --git a/scripts/local-setup.ps1 b/scripts/local-setup.ps1
@@ -18,8 +18,11 @@ if ($isBeta) {
     $content -replace '"newVersionNotification": "stable"', '"newVersionNotification": "beta"' | Set-Content ../bld/devproxyrc.json
 }
 
+# Set icon filename
+$icon = $isBeta ? "icon-beta.ico" : "icon.ico"
+
 # Add installer icon
-Copy-Item ../media/icon.ico ../bld/icon.ico
+Copy-Item "../media/$icon" "../bld/$icon"
 
 # Set installer filename
 $installer = $isBeta ? "install-beta.iss" : "install.iss"