feat: example app and waku_destroy

[richard-ramos]

No description provided.

[SionoiS]

Very nice thanks!

Would it be useful to store the node config in WakuNodehandle, only on Running nodes allow call to waku_destroy then return an Initialized node?

[Ivansete-status]

LGTM! Very educational PR, thanks for it!
qq: why waku_destroy is needed? We don't have such concept in nwaku-libwaku.

[Ivansete-status]

Maybe it worth adding a little comment above

[richard-ramos]

qq: why waku_destroy is needed? We don't have such concept in nwaku-libwaku.

The reason why it is necessary is because in waku_new we are creating a context running its own thread, yet we're not stopping that thread nor releasing the resources allocated by the Context by calling stopWakuNodeThread .

In waku-org/nwaku#2499 I added the waku_destroy function which calls that function, so we can do a proper cleanup of the resources used by waku when we no longer require a node. (Think of it as a graceful shutdown)

[Ivansete-status]

qq: why waku_destroy is needed? We don't have such concept in nwaku-libwaku.

The reason why it is necessary is because in waku_new we are creating a context running its own thread, yet we're not stopping that thread nor releasing the resources allocated by the Context by calling stopWakuNodeThread .

In waku-org/nwaku#2499 I added the waku_destroy function which calls that function, so we can do a proper cleanup of the resources used by waku when we no longer require a node. (Think of it as a graceful shutdown)

Wonderful! Thanks for that!

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 15.07937% with 107 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (nwaku@69a4872). Click here to learn what that means.

Files	Patch %	Lines
examples/basic/src/main.rs	0.00%	107 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             nwaku      #99   +/-   ##
========================================
  Coverage         ?   70.00%           
========================================
  Files            ?       11           
  Lines            ?      860           
  Branches         ?        0           
========================================
  Hits             ?      602           
  Misses           ?      258           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.