Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: hide *mut c_void behind WakunodeContext #96

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Conversation

richard-ramos
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 91.04478% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (nwaku@c434e9e). Click here to learn what that means.

Files Patch % Lines
waku-bindings/src/node/relay.rs 50.00% 4 Missing ⚠️
waku-bindings/src/node/mod.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             nwaku      #96   +/-   ##
========================================
  Coverage         ?   81.06%           
========================================
  Files            ?       10           
  Lines            ?      697           
  Branches         ?        0           
========================================
  Hits             ?      565           
  Misses           ?      132           
  Partials         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-ramos richard-ramos merged commit 646f6f0 into nwaku Feb 26, 2024
4 of 8 checks passed
@richard-ramos richard-ramos deleted the nwaku-ctx branch February 26, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants