Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: make web application port and hostname configurable #64

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

robvdl
Copy link
Member

@robvdl robvdl commented Mar 29, 2024

Make web application port and hostname configurable.

  • SAMBAL_HOST sets the hostname, defaulting to 127.0.0.1
  • SAMBAL_PORT sets the port, defaulting to 8000

The default host shouldn't be set to 0.0.0.0, because serving on all interfaces by default isn't the best for security.

But this makes it possible for the user to set it to 0.0.0.0, or a different port.

* SAMBAL_HOST sets the hostname, defaulting to 127.0.0.1
* SAMBAL_PORT sets the port, defaulting to 8000

The default host shouldn't be set to 0.0.0.0, because serving on all interfaces by default isn't the best for security.

But this makes it possible for the user to set it to 0.0.0.0, or a different port.
@robvdl robvdl merged commit 557642c into master Mar 29, 2024
1 check passed
@robvdl robvdl deleted the configure-host branch March 29, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant