login: fix redirect traversal bugs #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two issues this fixes:
1. When using Traversal (which hasn't been committed yet), request.matched_route will be None which crashes if you access request.matched_route.name
2. It needed to look at the request method (being POST or GET), otherwise it always ended up redirecting to request.route_path("home").
This part should never have run if the request method was POST:
>>> return_url = request.route_path("home")
Closes #28
|
It probably wouldn't hurt writing additional testcases for this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues this fixes:
When using Traversal (which hasn't been committed yet), request.matched_route will be None which crashes if you access request.matched_route.name
It needed to look at the request method (being POST or GET), otherwise it always ended up redirecting to request.route_path("home").
This part should never have run if the request method was POST:
Closes #28