Merge pull request k0rdent#356 from eromanova/template-immutable

Validate that Templates spec is immutable
wahabmk · Sep 20, 2024 · c757bb2 · c757bb2
2 parents 13b5245 + 05ace0c
commit c757bb2
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 0 deletions.
diff --git a/api/v1alpha1/clustertemplate_types.go b/api/v1alpha1/clustertemplate_types.go
@@ -30,6 +30,7 @@ type ClusterTemplate struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Spec is immutable"
 	Spec   ClusterTemplateSpec   `json:"spec,omitempty"`
 	Status ClusterTemplateStatus `json:"status,omitempty"`
 }

diff --git a/api/v1alpha1/providertemplate_types.go b/api/v1alpha1/providertemplate_types.go
@@ -30,6 +30,7 @@ type ProviderTemplate struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Spec is immutable"
 	Spec   ProviderTemplateSpec   `json:"spec,omitempty"`
 	Status ProviderTemplateStatus `json:"status,omitempty"`
 }

diff --git a/api/v1alpha1/servicetemplate_types.go b/api/v1alpha1/servicetemplate_types.go
@@ -30,6 +30,7 @@ type ServiceTemplate struct {
 	metav1.TypeMeta   `json:",inline"`
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Spec is immutable"
 	Spec   ServiceTemplateSpec   `json:"spec,omitempty"`
 	Status ServiceTemplateStatus `json:"status,omitempty"`
 }

diff --git a/templates/provider/hmc/templates/crds/hmc.mirantis.com_clustertemplates.yaml b/templates/provider/hmc/templates/crds/hmc.mirantis.com_clustertemplates.yaml
@@ -130,6 +130,9 @@ spec:
             required:
             - helm
             type: object
+            x-kubernetes-validations:
+            - message: Spec is immutable
+              rule: self == oldSelf
           status:
             description: ClusterTemplateStatus defines the observed state of ClusterTemplate
             properties:

diff --git a/templates/provider/hmc/templates/crds/hmc.mirantis.com_providertemplates.yaml b/templates/provider/hmc/templates/crds/hmc.mirantis.com_providertemplates.yaml
@@ -130,6 +130,9 @@ spec:
             required:
             - helm
             type: object
+            x-kubernetes-validations:
+            - message: Spec is immutable
+              rule: self == oldSelf
           status:
             description: ProviderTemplateStatus defines the observed state of ProviderTemplate
             properties:

diff --git a/templates/provider/hmc/templates/crds/hmc.mirantis.com_servicetemplates.yaml b/templates/provider/hmc/templates/crds/hmc.mirantis.com_servicetemplates.yaml
@@ -130,6 +130,9 @@ spec:
             required:
             - helm
             type: object
+            x-kubernetes-validations:
+            - message: Spec is immutable
+              rule: self == oldSelf
           status:
             description: ServiceTemplateStatus defines the observed state of ServiceTemplate
             properties: