Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snuco 레스토랑 이름 고정 #82

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

GanziDaeyong
Copy link
Contributor

@GanziDaeyong GanziDaeyong commented Apr 20, 2024

Pull Request

설명

snuco의 경우 식당 이름을 하드코딩했습니다. 번호를 기준으로 판단하도록 했습니다.
그 외 (수의대, 기숙사)는 따로 번호가 나오지 않아 그냥 뒀습니다. 애초에 이름이 문제였던 경우는 다 snuco이기도 했구요.

어떤 종류의 PR인가요?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

테스트는 어떤 방식으로 진행하셨나요?

  • Unit Test with pytest
  • Integration Test with pytest
  • Manual Test

체크리스트

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor Author

@GanziDaeyong GanziDaeyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남깁니다.

crawlers/snuco_crawler.py Show resolved Hide resolved
crawlers/snuco_crawler.py Show resolved Hide resolved
handler.py Show resolved Hide resolved
slack.py Show resolved Hide resolved
Copy link
Member

@GoGiants1 GoGiants1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수명이 조금 헷갈리는 부분이 있어서 코멘트 남겼습니다. 이외에는 LGTM 입니다~~ 🎉

handler.py Show resolved Hide resolved
@GoGiants1 GoGiants1 merged commit 45b1650 into dev Jul 1, 2024
3 checks passed
@GoGiants1 GoGiants1 deleted the feat/restaurant_by_phone branch July 1, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants