Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 더이상 ths내 type 존재 않음 #72

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix: 더이상 ths내 type 존재 않음 #72

merged 1 commit into from
Feb 26, 2024

Conversation

GanziDaeyong
Copy link
Contributor

@GanziDaeyong GanziDaeyong commented Feb 26, 2024 •
edited
Loading

🍣 변경 사항

  • meal type 표기 위치가 th 태그에서 빠진 것으로 판단됨. 이제는 tr 내 td의 class에 "breakfast", "lunch", "dinner" 가 표시되길래 이를 활용했음. 다만 이전에 th와 td에 중복하여 type 정보가 있었는지, 아니면 이번에 th에서 빠지면서 td로 저기로 이동한건지는 모르겠음.
  • 참고로 td.breakfast를 파고 들어가면 "아침" 이라는 토큰을 얻을 수 있을 것 같긴 한데, 공시적으로 class 명을 breakfast, lunch, dinner로 쓰고있는 만큼 굳이 그럴 이유는 없다고 생각했슴니다.

@GoGiants1
Copy link
Member

머지할게요~

@GoGiants1 GoGiants1 merged commit aef44f8 into fix/snuco-index-error Feb 26, 2024
1 check passed
@GoGiants1 GoGiants1 deleted the fix/snuco-index-daeyong branch February 26, 2024 08:19
GanziDaeyong added a commit that referenced this pull request Feb 26, 2024
@GoGiants1 @GanziDaeyong
fix index error (#71)
9bce8aa 
* fix index error

* fix: 더이상 ths내 type 존재 않음 (#72)

* Fix vet crawler

* 두레미담 주문식 메뉴 수정 & 자하연 식당 이름 수정

---------

Co-authored-by: iwin1203 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GoGiants1 GoGiants1 GoGiants1 approved these changes

@invalidid56 invalidid56 Awaiting requested review from invalidid56

@tomatozoo tomatozoo Awaiting requested review from tomatozoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GanziDaeyong @GoGiants1