comment AllowAny & comment author_username / author_info #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ding-young
reviewed
Jul 29, 2022
| @@ -38,6 +41,9 @@ def get_author_id(self, obj): | |||
| def get_author_username(self, obj): | |||
| return obj.author.username | |||
|
|
|||
| def get_author_info(self, obj): | |||
| return UserViewSerializer(obj.author).data | |||
|
|
|||
| def get_comments_counts(self, obj): | |||
| print(type(obj.comments)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #<issue No.1>, #<issue No.2> ...
해결/개선하고자 한 기능 설명
만인이 Q&A의 댓글을 볼 수 있게 -> AllowAny (임시조치)
댓글 작성자의 유저명을 볼 수 있게 -> author_username field
alarm을 끈 유저 -> GET /circle/{id}/user/{id}/alarm/에서 live_recruitment_alarm 필드 숨김
실제로 해결/개선한 방식
나중에 추가로 해결/개선해야하는 사항
UserViewSerializer의 공격적인 도입?