XmlSerializer Memory Leak Fix #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e XmlSerializer causes a serious memory leak if you do not use the two contructors mentioned here. https://support.microsoft.com/en-us/help/886385/memory-usage-is-high-when-you-create-several-xmlserializer-objects-in-asp-net From my testing this change also bumps performance atleast 2 fold with repetitive bulk saves
|
Thanks for the contribution! Before we can merge this, we need @nrubino to sign the Salesforce Contributor License Agreement. |
|
Great job! This took my 100k bulk upload from 20 mins down to just under 3 mins. Memory usage went from 6GB down to normal 1GB. Amazing! Well done. |
|
Are we going to be able to get this merged? This PR has been out there for a bit. Thanks! |
Do I need to do something? |
|
@nrubino seems you need to re-merge master into your topic branch, resolve any conflicts and push back up. |
|
Looks like some stuff still might need to be done before this can be pulled in. |
|
This was a huge help, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he XmlSerializer causes a serious memory leak if you do not use the two contructors mentioned here.
https://support.microsoft.com/en-us/help/886385/memory-usage-is-high-when-you-create-several-xmlserializer-objects-in-asp-net
From my testing this change also bumps performance atleast 2 fold with repetitive bulk saves