-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Improve & Update Typechain Polkadot #2289
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WookashWackomy thanks for the application. Usually we require all the mandatory deliverables 0a - 0e. that are present in the application template. Could you please add these to each milestone and move the current deliverables underneath starting with 1., 2., etc.
An article is only mandatory for the last milestone, and if we can run everything with pnpm or yarn it's probably fine to remove Docker. Thanks!
Hello, sure. Just updated the proposal with your suggestions. I've left the Docker but marked as optional - perhaps it would be handy to provide a Dockerfile with a strictly set runtime & all of the deps just for the sake of testing the project without the need to use local environment. Though I'm not 100% sure if it makes sense in a real life scenario. That being said - it's there and we'll try to make it in a way to be useful. Thanks for the feedback! |
Thanks @WookashWackomy I'm going to mark this as on hold for now until we know more about the future of ink! Will get back to you in the coming days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. What's the status of the Brushfam repo, is Brushfam still involved in Typechain's maintenance? My main concern for such a grant would be that we need to make sure that the work is merged into the main repo, instead of you having to maintain a fork and thus possibly splitting the community.
Brushfam has not been maintaing the project for a long time and did clearly state that if we, community want to make any updates/changes we have to create a fork :/
Regarding hosting: We've been debating about hosting it in an appropriate place for such project - https://github.com/inkdevhub/ and creating a wide group of maitainers from different teams/projects. That would make possible to act quickly at least when a community member creates a PR - which was difficult to achieve for for a long time and forced people to fork the project. (Offtopic note - we've been thinking about hosting Pendzl on inkdevhub as well and will attempt to do it soon) |
Co-authored-by: Sebastian Müller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inkdevhub might be a good place. Once the ink! team has reestablished itself, they might have an opinion on this as well.
Hello @semuelle. Could you share an update on the state of the approval process of this proposal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @WookashWackomy, sorry for the delay. I am happy to support the project and will share it with the rest of the committee. They will probably have comments and questions in the coming days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @WookashWackomy based on your previous work I'm also happy to approve. But curious what steps you will take afterwards to gain more traction with this tool?
Thanks @keeganquigley for the approve. Let me somehow reiterate here - the goal of so called "typechain" is to be an important piece & facilitator in areas such as building, scripting, testing etc. Therefore a great, and honestly the best way to get traction is to prove it is such building block indeed - by providing examples of usage in real life projects. |
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Project Abstract
A reliable, developer friendly typegen tool is crucial for the developer ecosystem.
This application aims to improve Typechain Polkadot, extending its capabilities & reworking parts of it that make it cumbersome to use.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)