-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SecuX Hardware Wallet supports Polkadot transactions and staking #2286
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
Hi @rus7hex thanks for the application. Currently, the milestone table is missing the default deliverables 0a. - 0e. as listed in our application template. Could you add these in? Docker might not be necessary in your case, so you can omit this, but the other sections should still apply. Thanks! |
Hey @rus7hex , |
Regarding Hardware wallets, historically speaking Ledger had a lot of trouble to offer a user friendly convenient solution for the whole substrate ecosystem as each chain required a different app. I'm not sure right now what the reason for this choice was. Possibly the need for different metadata for different chains. Even worse was the problem that the addresses of accounts that are associated with a single ledger app for a substrate chain could be converted with tools like subscan which led to the issue that people sent funds to this converted address on other chains assuming that their ledger will have exactly this converted address in the app for the other chain. Yet ledger apps for different chains are not sharing one underlying account so addresses varied. How are you solving this problem which led ledger to this decision? Preferrably you can come up with a concept that drastically improves this UX mess for users. Looking forward to your answers. |
More in scope of this very Polkadot only specific application I have a question regarding "Seed phrase generation and management, signing a transaction and staking." which you listed as key-deliverable. "Signing a transaction" is a somewhat very vaguely specified deliverable. As you probably know Polkadot and other Substrate based chains use multiple pallets each with different extrinsics. So does this key-deliverable now mean that you will support ALL extrinsics that Polkadot offers or are you just describing the process of transacting tokens? E.g. sending Tokens from one account to another? I'm asking because if you were to support all extrinsics there wouldn't be the need to specify functionality for staking as an additional deliverable. TLDR: What exactly means "signing a transaction" as a deliverable? Does the deliverable about staking compatibility mean that you are supporting ALL staking related extrinsics? Thank you for your clarification. |
The SecuX wallet notably facilitates the creation of up to 500 distinct addresses from a singular seed phrase, offering Polkadot users a streamlined and secure method to manage various cryptocurrency assets across multiple blockchains. This capability underscores the wallet's utility in enhancing the operational efficiency and safety for individuals engaging with diverse digital currencies.
SecuX is dedicated to providing support for both transaction signing and staking on the Polkadot and Kusama networks. This commitment equips our users with comprehensive tools that are vital for efficiently managing and enhancing their digital assets within these ecosystems. Additionally, we are keen and open to exploring collaboration opportunities with other parachains in various proposals. We believe that such cooperative efforts can yield mutually beneficial outcomes and drive further innovation within the community. |
@PieWol please let us know if a meeting is needed for the review, thank you. |
Thanks @rus7hex most of the team is traveling for a team retreat this week so will probably be early next week before more feedback is given. Thanks for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rus7hex. Thanks for the application and the effort you put into it. Correct me if I'm wrong, but it looks to me as if the software you are building is based around proprietary hardware, which is something we usually try to avoid. Also, large parts of this project are dependent on successfully merging changes into the staking dashboard and polkadot.js apps repos, which we have had mixed success with, so I'm wondering if there was a better way to integrate, like working with Talisman or other wallets.
applications/secux_hardware_wallet_support_polkadot_transactions_and_staking.md
Outdated
Show resolved
Hide resolved
| 3. | SecuX SE Firmware version number | Development of Secure Element (SE) Firmware. | | ||
| 4. | SecuX MCU Firmware version number | Development of MCU Firmware including transection confirmation, transection details, account balance. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these called version number
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have specific SE firmware version and MCU firmware version supporting Polkadot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand, I'm just a bit confused why that's the name of the deliverable when the actual work being done for it is software development. Could you expand a bit on what exactly needs to be implemented for these deliverables that's specific to Polkadot? Account generation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
To implement and verify compatibility with BIP32-ED25519 seed phrase recovery, ensuring that accounts generated by Ledger are compatible with SecuX and vice versa. Users can switch between Ledger and SecuX devices without worrying about compatibility issues.
-
Display the Polkadot (DOT) cryptocurrency icon on the front end of the SecuX Web Wallet app.
-
Support Polkadot (DOT) cryptocurrency send/receive functions, including transaction history, via the SecuX Web Wallet and SecuX Hardware Wallet through WebUSB or Bluetooth.
-
Prompt the user to confirm the transaction amount and receiver address on the SecuX Hardware Wallet.
| 3. | SecuX SE Firmware version number | Development of Secure Element (SE) Firmware. | | ||
| 4. | SecuX MCU Firmware version number | Development of MCU Firmware including transection confirmation, transection details, account balance. | | ||
| 5. | SecuX SDK Polkadot integration tutorial | Provide SDK API for Polkadot.js. | | ||
| 6. | SecuX Web Wallet Firmware update | Distribute Polkadot SE and MCU Firmwares. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you distribute the firmware? Please note that all deliverables should ideally be reusable, so please specify or remove. See also our FAQ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates will be done through our SecuX web wallet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate what is being delivered here? To reiterate, all deliverables should be reusable and verifiable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revising
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still working on this, @dannyhuang213?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rus7hex is helping to update it now, thank you for your patience.
applications/secux_hardware_wallet_support_polkadot_transactions_and_staking.md
Outdated
Show resolved
Hide resolved
| **0b.** | Documentation | We will deliver a comprehensive "How It Works" guide covering three critical aspects of interacting with the Polkadot network: generating a Polkadot address, confirming a transaction, and engaging in staking. This guide will provide users with step-by-step instructions, ensuring they have a clear understanding of each process, which is essential for secure and effective participation in the Polkadot ecosystem. | | ||
| **0c.** | Testing and Testing Guide | We will supply a detailed testing guide along with a SecuX hardware wallet to thoroughly verify the new functionalities. This approach will ensure that all features are tested under real-world conditions, providing users with reliable and secure solutions within the ecosystem. | | ||
| 0e. | Article | We will create and publish an in-depth article that explores the various supports and functionalities of the Polkadot network. Additionally, we will enhance the article's reach through a co-marketing initiative on social media with Polkadot. This strategic partnership will not only educate our audience about Polkadot's capabilities but also amplify our content's visibility and engagement across platforms. | | ||
| 1. | Periodically Meeting | Collaborative Efforts and Communication, Polkadot Integration of SecuX SDK support. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is meeting here? See my note below on reusability of deliverables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of the periodic meeting is to gain a comprehensive understanding of Polkadot's JavaScript user interface and its staking dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sebastian @semuelle please feel free to let us know if you have any questions, we will be happy to clarify things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of the periodic meeting is to gain a comprehensive understanding of Polkadot's JavaScript user interface and its staking dashboard.
That doesn't answer my question. Please keep in mind that deliverables in the grants program should be reusable and verifiable, which meetings usually aren't (unless the deliverable is a result of these meetings).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revising
The primary purpose is to support Polkadot, our hardware wallet is built using industry-standard architecture like an MCU and a Secure Element. |
Hey @rus7hex , I'm wishing you all the best going forward. |
We will continue to support Polkadot and list it as one of our standard offerings. Not only do we care about our reputation, but also our customers' experience and success. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannyhuang213 thanks for your interest in our grants program and the work you put into this thus far. Unfortunately, I've decided to not add my approval, since I agree with my colleagues on their reasonings
I also want to mention that our funding guidelines require all produced code to be open-sourced and independent of closed-source software:
All code produced as part of a grant must be open-sourced, and it must also not rely on closed-source software for full functionality. We prefer Apache 2.0, but GPLv3, MIT, or Unlicense are also acceptable.
I know, in your case it's technically hardware (though one could argue that the hardware is programmed with proprietary software as well), but I think the dependency is comparable.
I appreciate your understanding and hope you'll continue to support Polkadot with your innovative hardware. Thanks again!
Hi @rus7hex & @dannyhuang213, thanks again for the application, but the committee has decided not to support it, the main reason being the use of proprietary hardware. We still hope that you will continue working on the project and I hope we will be able to work together sometime, somewhere in the future. |
Project Abstract
Integrating cutting-edge SecuX hardware wallets equipped with multi-factor authentication and secure chip technology, Polkadot provides both holders of high-value assets a secure and intuitive way to protect their investments, and bolsters the total value locked (TVL) within the network. This partnership highlights Polkadot's commitment to crafting a secure and reliable investment environment, attracting high-value investors for long-term engagement.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)