Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liisa portfolio tracker application update #2103

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

LiisaNFT
Copy link
Contributor

Dear all,

After consulting with the W3F team, we hereby submit the following changes to our initial application:

  1. Removing Moonsama and Unique Network support:
  • With Moonsama, we're having trouble identifying sales and values due to complexities in decoding the Raresama marketplace's functions. Our talks with the Moonsama/Raresama team are ongoing, but we haven't found a fix yet.

  • For Unique Network, the lack of an archive on Subsquid means we can't index data for Unique NFTs right now. We're in active talks with the teams at Subsquid and Unique Marketplace to sort this out, but there's no solution yet.

  • The remaining chains/protocols have been integrated successfully. We think focusing on what we can deliver right now for operational chains is better so that we can resume to the next stage of the project.

  • We have updated the Components section accordingly, as well as the milestone tables.

  1. Increasing the project’s timeline
  • In light of these issues, we're proposing an adjusted timeline. As suggested by the W3F team, we’re adding one month to Milestone 1, due to the challenges we have faced, and an additional month to Milestone 2, to account for unforeseen challenges that might arise in this next stage.

  • We have updated the Development roadmap / milestone tables accordingly

  1. Migration to GCP
  • We will no longer be using AWS, but GCP to host the solution.

  • We have updated the Components section accordingly.

Updated chain support, deadlines and cloud provider
@keeganquigley
Copy link
Contributor

Thanks for the updates @LiisaNFT looks good to me. I will mark the amendment as ready for review and ping the committee.

@keeganquigley keeganquigley self-assigned this Nov 13, 2023
@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. labels Nov 13, 2023
@takahser
Copy link
Collaborator

@LiisaNFT thanks for the update. I'm fine with most changes, but I didn't quite understand the issue with Moonsama. For example, it's compatible with subsquid, so you'd get the sale data from the transactions, right? Also, what did your contacts at Moonsama say, if you don't mind asking?

image

@LiisaNFT
Copy link
Contributor Author

Dear @takahser, thank you for your feedback.

In regards to Moonsama, Subsquid is indeed capable of indexing the chain and we are currently able to index ERC721 and ERC1155 transfers, since the ABIs for the token standards are equal across all EVM chains, meaning we can "listen" to and decode these transactions.

Our challenge comes from identifying the ABIs from the marketplaces (Raresama in this case) so that we're able to decode transactions on these marketplaces, such as sales - which include not only the transfer of the ERC721/1155 token, but other information such as the sales price (a native token transfer), marketplace fees, etc.

The Moonsama team has told us that they are not able to provide us with their marketplace's ABI. They also mentioned they are developing (or planning to develop) their own API for this purpose, which isn't yet available.

Hope this answers your question, let us know if you need any further clarification!

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LiisaNFT thanks for your reply.

The Moonsama team has told us that they are not able to provide us with their marketplace's ABI.

If that's the case, I'm happy to approve the amendment.

@takahser takahser merged commit fdc29dc into w3f:master Nov 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants