Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CoinFabrik_On_Ink_Integration_Tests-2 #1043

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Add CoinFabrik_On_Ink_Integration_Tests-2 #1043

merged 2 commits into from
Nov 20, 2023

Conversation

valeriacaracciolo
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1980 < please fill this in with the PR number of your application.

@XianPaz XianPaz mentioned this pull request Oct 31, 2023
Open
@valeriacaracciolo valeriacaracciolo mentioned this pull request Nov 1, 2023
Merged
10 tasks
@keeganquigley
Copy link
Contributor

Thanks for the delivery @valeriacaracciolo we will take a look at it in the next couple of days.

@valeriacaracciolo
Copy link
Contributor Author

Thank you @keeganquigley We look forward to the review. Best,

@keeganquigley keeganquigley self-assigned this Nov 9, 2023
@valeriacaracciolo
Copy link
Contributor Author

Hello, we noticed some failing checks with our PRs. We are working on resolving these issues and we estimate it should be solved by the end of next week.

@keeganquigley
Copy link
Contributor

Hi @valeriacaracciolo sorry for the delay, we have been a bit behind due to recent organizational changes. I'm looking at this now. I see that one of the PRs in the delivery has been closed. Are there plans to re-open this?

Also, the other two are still open. Have you talked to the team to see if there is a timeline as to when these can be looked at and merged?

@valeriacaracciolo
Update PRs in CoinFabrik_On_Ink_Integration_Tests-2.md
76a7092 
We explain below two changes that we had to perform to ensure that our PRs passed the corresponding checks, and to be consistent with new developments we have performed on other unimplemented functions in integration tests.

We initially performed the Pull Request [#1963](use-ink/ink#1963) to implement instantiate_contract(), but decided to close it and perform a new Pull Request [#1988](use-ink/ink#1988) to include necessary implementations of other related functions, which were developed as a subsequent milestone to this Milestone 2. These functions were all related to each other, and a single PR seemed like the tidiest option.

As part of an ad-hoc development in PR [#58] (use-ink/cargo-contract#1358), adding support to workspaces, we were requested to ensure that ink-examples worked correctly with this implementation. We initially performed the Pull Request [#44](use-ink/ink-examples#44) to show this. However, we had to close this PR because some modifications needed to be performed for checks to pass. We made these changes in Pull Request [#52](use-ink/ink-examples#52).

We updated the Milestone Report and Table of Deliveries to reflect these final changes.
@keeganquigley
Copy link
Contributor

Thanks for the updates @valeriacaracciolo here you can find my final evaluation. I'm happy to pass the milestone and great job on the completion of the grant!

@keeganquigley keeganquigley merged commit 6bc7b00 into w3f:master Nov 20, 2023
3 checks passed
@github-actions GitHub Actions
Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

@github-actions GitHub Actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@github-actions GitHub Actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@valeriacaracciolo
Copy link
Contributor Author

Thanks for the updates @valeriacaracciolo here you can find my final evaluation. I'm happy to pass the milestone and great job on the completion of the grant!

Thank you for your evaluation @keeganquigley !

@RouvenP
Copy link

RouvenP commented Dec 1, 2023

hi @valeriacaracciolo we just transferred the payment

@valeriacaracciolo
Copy link
Contributor Author

Thank you @RouvenP Received

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keeganquigley keeganquigley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valeriacaracciolo @keeganquigley @RouvenP