Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outbound-rtp: add active flag #649

Merged
merged 1 commit into from
Jul 26, 2022
Merged

outbound-rtp: add active flag #649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions webrtc-stats.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,6 +1659,7 @@ <h3>
unsigned long firCount;
unsigned long pliCount;
DOMString encoderImplementation;
boolean active;
};</pre>
<section>
<h2>
Expand Down Expand Up @@ -2005,6 +2006,17 @@ <h2>
Since it is only given for active tracks, the incremental exposure is small.
</p>
</dd>
<dt>
<dfn>active</dfn> of type <span class=
"idlMemberType">boolean</span>
</dt>
<dd>
<p>
Indicates whether this <a>RTP stream</a> is configured to be sent or disabled.
fippo marked this conversation as resolved.
Show resolved Hide resolved
Note that an active stream can still not be sending, e.g. when being limited by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think we will need a counter for the number of times the status flips between active and limited.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This flag isn't supposed to flip on its own and only modifiable via setParameters which we don't count.
For limited see #650 but that is partially captured by qualityLimitationDurations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a counter for number of times setParameters flips this value makes little sense and is not very useful in my opinion. This metric is useful on its own and in fact very much needed for making sense of simulcast stats. Today you can't really tell "what is the highest resolution layer currently being sent?" or similar questions. We desperately need it for making sense of simulcast :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that qualityLimitationDurations is enough, this is more about the effects of the current limitation

network conditions.
</p>
</dd>
</dl>
</section>
</div>
Expand Down