RTCScalableVideoCodecLayerStats added #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this only for the sent SVC? what about received svc? |
|
Only sent for now, let's discuss if receiving metrics are useful |
|
WEBRTC-SVC doesn't define access to layers yet. Let's not do anything with it before the definition there lands. |
alvestrand
reviewed
Apr 21, 2020
| @@ -392,6 +395,7 @@ <h3> | |||
| "codec", | |||
| "inbound-rtp", | |||
| "outbound-rtp", | |||
| "svc-layer", | |||
There was a problem hiding this comment.
we should also add an "SVC mode" value to the video RTP sender, I think.
There was a problem hiding this comment.
Yes that makes sense!
The per-layer access is discussed here: w3c/webrtc-svc#14 (comment) Tag @Orphis if we want SVC stats this is blocked on the referenced SVC API. This stats PR is iceboxed in the meantime. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #401
Preview | Diff