Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated vsso [instances, annotation] #41

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Updated vsso [instances, annotation] #41

wants to merge 3 commits into from

Conversation

danielwilms
Copy link
Contributor

Output of new tooling in COVESA/vss-tools#160

  • DVP now instances
  • use of skos:definition instead of rdfs:comment
  • rdfs:comment where vss uses comments (new in 3.0)
  • dot notated path in separate annotation property

Signed-off-by: Daniel Wilms [email protected]

@danielwilms
Updated vsso [instances, annotation]
e7e4158 
Output of new tooling in COVESA/vss-tools#160

- DVP now instances
- use of `skos:definition` instead of `rdfs:comment`
- `rdfs:comment` where vss uses comments (new in 3.0)
- dot notated path in separate annotation property

Signed-off-by: Daniel Wilms <[email protected]>
@felix-loesch
Copy link

Great to see that DVP are now instances!

Can we add the linkage from the DVP instance to the VehicleComponent? For example, vsso-signals:EngineCoolantTemp vsso-core:belongsToVehicleComponent vsso-signal:Engine)

@danielwilms
Copy link
Contributor Author

@felix-loesch, that's something we have to discuss later. It's possible only, if we instantiate the vehicle components as well...So I decided yesterday to discuss it first, before I implement it.

@danielwilms
Copy link
Contributor Author

Decision in meeting on 2022/05/16: creating the vehicle components as instances:

  • possible to create subclass structure later on
  • currently not sufficient information in VSS to have sub-classes in generation
  • work well together with DVP as instances

@danielwilms
[VSSo] Vehicle components as instances
f707960 
`Branch`es of VSS are now modeled as instances of `vsso-core:VehicleComponent`
and not as `rdfs:subClass` anymore.

Two challenges reside:
1. Shall there be an instance of `vsso:Vehicle` or punning of `vsso-core:Vehicle`?
   Challenge araises, when you use the `partOf` relationship.
2. Restrictions on Static Vehicle properties.

Signed-off-by: Daniel Wilms <[email protected]>
@danielwilms
Copy link
Contributor Author

Meeting 2022/06/13:

Point from the PR:

Shall there be an instance of vsso:Vehicle or punning of vsso-core:Vehicle?
Challenge araises, when you use the partOf relationship.

Option 1: No root instance node of vehicle components
Option 2: Connecting to vsso-core:Vehicle, but then annotation property is necessary
Option 3: Having an instance vsso:Vehicle as über-VehicleComponent as root of the instances

we go for now with option 3 and discuss further.

danielwilms added a commit to danielwilms/vss-tools that referenced this pull request Jun 14, 2022
@danielwilms
Adding vsso:Vehicle as an instance of vsso-core:VehicleComponent
a65d81e 
Change reflecting discussion in:
w3c/vsso#41 (comment)

Signed-off-by: Daniel Wilms <[email protected]>
erikbosch pushed a commit to COVESA/vss-tools that referenced this pull request Jun 14, 2022
@danielwilms
VSSo: VehicleComponents as instances (#171)
e282e9f 
* VSSo: VehicleComponents as instances

Currently the VehicleComponents were modelled as
subclasses with `rdfs:subclass`. This change introduces
a variable to choose either way until it's decided.

Additionally introduced documentation improvements and
code cleanups.

Mentioned in: w3c/vsso#22

Signed-off-by: Daniel Wilms <[email protected]>

* Adding `vsso:Vehicle` as an instance of `vsso-core:VehicleComponent`

Change reflecting discussion in:
w3c/vsso#41 (comment)

Signed-off-by: Daniel Wilms <[email protected]>
@danielwilms
Copy link
Contributor Author

@danielwilms checks if option3 is implemented. If so, PR can be merged. Otherwise merged after implementation.

@jdacoello
Copy link

@danielwilms to provide update on status of implementation of option 3.

@danielwilms
Copy link
Contributor Author

Implementation done. ttl file to be updated.

@danielwilms
Update vss ttl file
488748e 
Updated ttl file, as implemented in vss-tools.
COVESA/vss-tools@c944887

Signed-off-by: Daniel Wilms <[email protected]>
@danielwilms
Copy link
Contributor Author

danielwilms commented Jul 25, 2022 •
edited
Loading

ttl file added. Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielwilms @felix-loesch @jdacoello