Add a section for the background blur field in VideoFrameMetadata #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markafoltz
commented
Nov 12, 2024
index.html
Outdated
| @@ -1876,6 +1876,76 @@ <h3>Examples</h3> | |||
| </pre> | |||
| </section> | |||
| </section> | |||
| <section> | |||
| <h2>Camera Effect Status</h2> | |||
| <p>The {{VideoFrameMetadata}} interface exposes the effect state as a property, | |||
There was a problem hiding this comment.
Suggested change
| <p>The {{VideoFrameMetadata}} interface exposes the effect state as a property, | |
| <p>The {{VideoFrameMetadata}} interface exposes the blur state as a property, |
index.html
Outdated
| <dl class="dictionary-members" data-link-for="VideoFrameMetadata" data-dfn-for="VideoFrameMetadata"> | ||
| <dt><dfn><code>background_blur</code></dfn> of type <code>{{BackgroundBlur}}</code></dt> | ||
| <dd> | ||
| <p>The state of the background blur effect for the current frame.</p> |
There was a problem hiding this comment.
Should explain what it means for the property to be present or missing.
index.html
Outdated
| <h3>{{BackgroundBlur}}</h3> | ||
| <pre class="idl"> | ||
| dictionary BackgroundBlur { | ||
| boolean enabled; |
There was a problem hiding this comment.
I think this should be a required property. If background_blur is present, enabled should have a value.
guidou
requested review from
alvestrand,
aboba,
jan-ivar,
youennf and
guidou
aboba
requested changes
Nov 22, 2024
| const videoTrack = stream.getVideoTracks()[0]; | ||
| const blurIndicator = document.getElementById("blurIndicator"); | ||
| const trackProcessor = new MediaStreamTrackProcessor({ track: videoTrack }); | ||
| const trackGenerator = new MediaStreamTrackGenerator({ kind: "video" }); |
There was a problem hiding this comment.
You need to use the standardized API (VideoTrackGenerator)
markafoltz
commented
Nov 26, 2024
| <section class="notoc"> | ||
| <h4>Members</h4> | ||
| <dl class="dictionary-members" data-link-for="VideoFrameMetadata" data-dfn-for="VideoFrameMetadata"> | ||
| <dt><dfn><code>background_blur</code></dfn> of type <code>{{BackgroundBlur}}</code></dt> |
There was a problem hiding this comment.
Properties should be camelCase.
| <section> | ||
| <h3>Example</h3> | ||
| <pre class="example"> | ||
| // main.js: |
There was a problem hiding this comment.
Is this contrasted with code in another .js file or elsewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/markafoltz/camera-effects for more details.
Preview | Diff