[css-backgrounds-4] Added background-repeat-* longhands #9756
Conversation
SebastianZ
force-pushed
the
background-repeat-longhands
branch
from
c7d8a54 to
508b7af
Compare
|
@SebastianZ since you are now an Editor of this spec, feel free to merge your own PR |
|
@svgeesus Thanks for your response and the review! I merged it now. While I'm an editor of the spec., I still like to get some feedback on the changes I make. Sebastian |
| Applies to: all elements | ||
| Inherited: no | ||
| Percentages: N/A | ||
| Computed value: list, each item a pair of keywords, one per dimension |
There was a problem hiding this comment.
Shorthands don't have a computed value of their own. Must be "see individual properties", as in https://drafts.csswg.org/css-flexbox-1/#flex-property
| <dl dfn-type=value dfn-for=background-repeat> | ||
| <dt><dfn>repeat-x</dfn> | ||
| <dd> | ||
| Computes to ''repeat no-repeat''. |
There was a problem hiding this comment.
Shorthands don't have a computed value of their own. I would say "Equivalent to repeat no-repeat", as in https://drafts.csswg.org/css-flexbox-1/#flex-common
| <p>If a <<repeat-style>> value has two keywords, the first | ||
| one is for the horizontal direction, the second for the vertical one. |
There was a problem hiding this comment.
You can be more explicit about the expansion: say that background-repeat-x is set to the first one, and background-repeat-y to the second.
Added the
background-repeat-x,background-repeat-y,background-repeat-blockandbackground-repeat-inlinelonghand properties as resolved in #116.I didn't add the logical values to the shorthand for now, because @Loirooriol expressed some valid concerns regarding that. I did add logical versions of the longhands as counterparts for the physical ones, though.
Sebastian