Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[css-nesting-1][editorial] Add a note recommending against mixing pro…
…perties and nested rules willy-nilly. #8349.
- Loading branch information
4c9c0b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of just mentioning error recovery, IMO it would be better to explain what will happen, e.g. the next declaration will be skipped, even if otherwise valid.
4c9c0b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually try to avoid getting into details about parsing unless absolutely necessary. If authors follow the advice they never need to know what the effects of not following it are; if they don't follow it they'll find out what the effects are pretty quick anyway. ^_^
4c9c0b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, and I'm not suggesting regurgitating all the error recovery behavior here (tho maybe a link would be useful), but at least mentioning that 'some content may be skipped' or something vague will still be useful to set expectations and help reinforce the 'proper way'.
4c9c0b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, done.
4c9c0b6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks