Default eslint config #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jugglinmike
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Looks good to me. Now that gh-71 is merged, we can move forward on removing those exceptions. Is that a quick patch for you, or would you like me to make a Task to track it?
| @@ -94,7 +94,7 @@ export function addTestLogToTestPlan(testPlan, { filepath: testFilepath }) { | |||
| */ | |||
| export function addTestResultToTestPlan(testPlan, testFilepath, result) { | |||
| const test = testPlan.tests.find(({ filepath }) => filepath === testFilepath); | |||
| const { testId, presentationNumber, ...resultOutput } = result; | |||
| const { testId, ...resultOutput } = result; | |||
|
We would need to do a full Typescript conversion to be able to remove those exceptions. Currently only JSDoc has type awareness because all of the relevant files except the type declarations are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #68
This PR adds a default eslint config. Unfortunately, two of the main rules that should be followed have to be disabled due to abnormal patterns.
empty-block pattern
These very unique pieces of code rely on an empty block. Since the collection being iterated on is
AsyncIterable<any>the most obvious way of avoiding the empty block is not available.no-unused-var
There are multiple points where an unused var is being used to support type inference.
It would be easier to add both of these rules back in after a Typescript conversion. For now, empty blocks and unused vars will at least produce warnings. Other rules from the eslint default config are now being enforced.