-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3501: Allow using more than one tuned profile #4179
Conversation
👍 |
✅ No issues found in unused-imports check.. Please refer the workflow run |
af8eb89
to
1aada1a
Compare
@Mergifyio rebase |
</valueHelp> | ||
<valueHelp> | ||
<format>virtual-guest</format> | ||
<description>Tune for running inside a virtual guest</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<description>Tune for running inside a virtual guest</description> | |
<description>Tune for running inside a virtual machine</description> |
You can run as a guest, but not inside it. If you are running inside a virtual machine, you are running as a guest.
<description>Tune for low network latency</description> | ||
</valueHelp> | ||
<valueHelp> | ||
<format>powersave</format> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<format>powersave</format> | |
<format>power-save</format> |
All other options separate words with hyphens, maybe this one should do that as well.
That will require a simple profile name mapping in the script, but we should probably do that anyway, since tuned profile names may change in the future.
</valueHelp> | ||
<valueHelp> | ||
<format>virtual-host</format> | ||
<description>Tune for running KVM guests</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<description>Tune for running KVM guests</description> | |
<description>Tune for running guest virtual machines</description> |
Theoretically, one still could use Xen, or some future hypervisor. I'd keep this generic.
1aada1a
to
029cde4
Compare
CI integration ❌ failed! Details
|
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
system option
Proposed changes
Added new TuneD profiles and ability to activate several profiles
How to test
Smoketest result
Checklist: