Add strict parameter to stream.zip #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smheidrich
commented
Jul 9, 2024
smheidrich
commented
Jul 9, 2024
smheidrich
force-pushed
the
gh-118-zip-strict
branch
from
d218eab to
b1a6fb4
Compare
smheidrich
commented
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1147 1173 +26
=========================================
+ Hits 1147 1173 +26 ☔ View full report in Codecov by Sentry. |
|
Thanks a lot @smheidrich for taking the time to create this PR, I'll try to find the time to make a proper review by the end of the week :) |
smheidrich
commented
Jul 10, 2024
smheidrich
commented
Jul 10, 2024
vxgmichel
reviewed
Jul 11, 2024
Co-authored-by: Vincent Michel <[email protected]>
Co-authored-by: Vincent Michel <[email protected]>
vxgmichel
approved these changes
Jul 19, 2024
Fix Pyton 3.8 compat Co-authored-by: Vincent Michel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118