Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/format/ci: use black stable style 2024; bump flake8 version; add black config to pyproject.toml #100

Closed
wants to merge 5 commits into from

Conversation

hf-kklein
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (4a2eff6) to head (7e45d75).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   99.30%   99.29%   -0.01%     
==========================================
  Files          15       15              
  Lines        1002      990      -12     
==========================================
- Hits          995      983      -12     
  Misses          7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hf-kklein hf-kklein changed the title chore/format/ci: Introduce black (stable style 2024) as code formatter; bump flake8 version chore/format/ci: use black stable style 2024; bump flake8 version May 5, 2024
@hf-kklein hf-kklein changed the title chore/format/ci: use black stable style 2024; bump flake8 version chore/format/ci: use black stable style 2024; bump flake8 version; add black config to pyproject.toml May 5, 2024
remove seconds empty line at EOF
Copy link
Owner

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking the time to create this PR, it's much appreciated :)

Why change the line length to 80 though? The default 88 looked fine to me.

@hf-kklein
Copy link
Contributor Author

Why change the line length to 80 though?

i don't know. this branch was stale for a while. changed it back to 88 now. aa2c49f

@hf-kklein hf-kklein requested a review from vxgmichel May 6, 2024 04:38
@vxgmichel
Copy link
Owner

The back and forth between 80 and 88 max length caused more changes than necessary.

I pushed those changes and migrated the rest of setup.cfg in PR #103.

Thanks for your valuable help :)

@vxgmichel vxgmichel closed this May 6, 2024
@hf-kklein
Copy link
Contributor Author

The back and forth between 80 and 88 max length caused more changes than necessary.

that's unexpected, because I thought black was so uncompromising, that the result would be reproducible even when switching between different lengths. but I don't mind ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants