-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/format/ci: use black stable style 2024; bump flake8 version; add black config to pyproject.toml #100
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 99.30% 99.29% -0.01%
==========================================
Files 15 15
Lines 1002 990 -12
==========================================
- Hits 995 983 -12
Misses 7 7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for taking the time to create this PR, it's much appreciated :)
Why change the line length to 80 though? The default 88 looked fine to me.
no idea, why I originally set 80
i don't know. this branch was stale for a while. changed it back to 88 now. aa2c49f |
The back and forth between 80 and 88 max length caused more changes than necessary. I pushed those changes and migrated the rest of setup.cfg in PR #103. Thanks for your valuable help :) |
that's unexpected, because I thought black was so uncompromising, that the result would be reproducible even when switching between different lengths. but I don't mind ;) |
No description provided.