[WIP] Update new UI #13

vutienduongeh · 2019-05-14T12:07:13Z

No description provided.

vutienduongeh · 2019-05-14T12:07:34Z

Don't merge it now.

houndci-bot · 2019-05-14T12:07:38Z

app/controllers/dashboards_controller.rb

+    @api_requests = {}
+  end
+
+  private


Lint/UselessAccessModifier: Useless private access modifier.

houndci-bot · 2019-05-14T12:07:39Z

app/controllers/dashboards_controller.rb

+      return
+    end
+
+    @today_order = Orders::RetrieveService.find_order_by_user_id_and_date session[:user_id], @select_date


Metrics/LineLength: Line is too long. [105/100]

houndci-bot · 2019-05-14T12:07:39Z

app/controllers/dashboards_controller.rb

+
+    return if @menu.blank?
+    if @select_date < Date.today ||
+        (@select_date == Date.today && @menu.is_lock? && Time.current > @menu.locked_at)


Rails/Date: Do not use Date.today without zone. Use Time.zone.today instead.

houndci-bot · 2019-05-14T12:07:39Z

app/controllers/dashboards_controller.rb

+    @menu = Menu.where('DATE(date)=?', @select_date).first
+
+    return if @menu.blank?
+    if @select_date < Date.today ||


Rails/Date: Do not use Date.today without zone. Use Time.zone.today instead.

houndci-bot · 2019-05-14T12:07:39Z

app/controllers/dashboards_controller.rb

+  before_action :require_login
+
+  def index
+    @select_date = Date.parse(params[:select_date].presence || Date.today.to_s)


Rails/Date: Do not use Date.today without zone. Use Time.zone.today instead.

houndci-bot · 2019-05-14T12:07:41Z

config/initializers/assets.rb

-# Rails.application.config.assets.precompile += %w( search.js )
+# application.js, application.css, and all non-JS/CSS in the app/assets
+# folder are already added.
+Rails.application.config.assets.precompile += %w( new_template.js new_template.css )


Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ].
Layout/SpaceInsidePercentLiteralDelimiters: Do not use spaces inside percent literal delimiters.

houndci-bot · 2019-05-14T12:07:41Z

app/views/layouts/sessions.html.haml

+    = stylesheet_link_tag 'new_template', media: 'all', 'data-turbolinks-track': true
+    = javascript_include_tag 'new_template', 'data-turbolinks-track': true
+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2019-05-14T12:07:41Z

app/views/layouts/sessions.html.haml

+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}
+    %link{href: "https://employmenthero.com/favicon-96x96.png", rel: "icon", sizes: "96x96", type: "image/png"}/
+    %link{href: "https://fonts.googleapis.com/css?family=Maven+Pro:400,500,700&subset=vietnamese", rel: "stylesheet"}/


Line is too long. [118/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2019-05-14T12:07:42Z

app/views/layouts/sessions.html.haml

+    = javascript_include_tag 'new_template', 'data-turbolinks-track': true
+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}
+    %link{href: "https://employmenthero.com/favicon-96x96.png", rel: "icon", sizes: "96x96", type: "image/png"}/


Line is too long. [112/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2019-05-14T12:07:42Z

app/views/layouts/sessions.html.haml

+%html
+  %head
+    %title EH Canteen
+    = stylesheet_link_tag 'new_template', media: 'all', 'data-turbolinks-track': true


Line is too long. [85/80]

houndci-bot · 2019-05-20T08:34:22Z

db/migrate/20181210220929_add_external_id_to_tag.rb

@@ -1,4 +1,4 @@
-class AddExternalIdToTag < ActiveRecord::Migration
+class AddExternalIdToTag < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T08:34:22Z

db/migrate/20180930160128_add_customizable_to_order.rb

@@ -1,4 +1,4 @@
-class AddCustomizableToOrder < ActiveRecord::Migration
+class AddCustomizableToOrder < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T08:34:23Z

db/migrate/20180205080312_create_dish_restaurant_association.rb

@@ -1,4 +1,4 @@
-class CreateDishRestaurantAssociation < ActiveRecord::Migration
+class CreateDishRestaurantAssociation < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T08:34:23Z

db/schema.rb

+  add_foreign_key "menu_histories", "menus"
+  add_foreign_key "orders", "users"
+  add_foreign_key "personal_settings", "users"
+  add_foreign_key "sized_prices", "dishes"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T08:34:23Z

db/schema.rb

+  add_foreign_key "dishes", "restaurants"
+  add_foreign_key "menu_histories", "menus"
+  add_foreign_key "orders", "users"
+  add_foreign_key "personal_settings", "users"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T08:34:25Z

db/schema.rb

+    t.datetime "updated_at", null: false
+    t.string "email"
+    t.string "password_digest"
+    t.integer "admin"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T08:34:25Z

db/schema.rb

+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.string "email"
+    t.string "password_digest"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T08:34:25Z

db/schema.rb

+    t.string "username"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.string "email"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T08:34:25Z

db/schema.rb

+  create_table "users", id: :serial, force: :cascade do |t|
+    t.string "username"
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T08:34:26Z

db/schema.rb

  end

+  create_table "users", id: :serial, force: :cascade do |t|
+    t.string "username"
+    t.datetime "created_at", null: false


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-20T12:34:36Z

db/migrate/20181210225758_add_external_id_to_restaurant.rb

@@ -1,4 +1,4 @@
-class AddExternalIdToRestaurant < ActiveRecord::Migration
+class AddExternalIdToRestaurant < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:36Z

db/migrate/20181210222954_add_external_id_to_dish.rb

@@ -1,4 +1,4 @@
-class AddExternalIdToDish < ActiveRecord::Migration
+class AddExternalIdToDish < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:36Z

db/migrate/20180605015854_personal_setting.rb

@@ -1,4 +1,4 @@
-class PersonalSetting < ActiveRecord::Migration
+class PersonalSetting < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:36Z

db/migrate/20180605015820_create_general_setting.rb

@@ -1,4 +1,4 @@
-class CreateGeneralSetting < ActiveRecord::Migration
+class CreateGeneralSetting < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:37Z

db/migrate/20180605013851_create_menu_history.rb

@@ -1,4 +1,4 @@
-class CreateMenuHistory < ActiveRecord::Migration
+class CreateMenuHistory < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:39Z

db/migrate/20180205035707_create_provider_dish_mapping_table.rb

@@ -1,4 +1,4 @@
-class CreateProviderDishMappingTable < ActiveRecord::Migration
+class CreateProviderDishMappingTable < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:39Z

db/migrate/20180203143751_create_daily_restaurant.rb

@@ -1,4 +1,4 @@
-class CreateDailyRestaurant < ActiveRecord::Migration
+class CreateDailyRestaurant < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:40Z

db/migrate/20180201074834_add_column_is_provider_to_restaurant.rb

@@ -1,4 +1,4 @@
-class AddColumnIsProviderToRestaurant < ActiveRecord::Migration
+class AddColumnIsProviderToRestaurant < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:40Z

db/migrate/20171212230416_add_author_to_notice.rb

@@ -1,4 +1,4 @@
-class AddAuthorToNotice < ActiveRecord::Migration
+class AddAuthorToNotice < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-20T12:34:40Z

db/migrate/20171212225536_create_notices.rb

@@ -1,4 +1,4 @@
-class CreateNotices < ActiveRecord::Migration
+class CreateNotices < ActiveRecord::Migration[4.2]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2019-05-24T11:48:44Z

db/schema.rb

  end

+  create_table "users", id: :serial, force: :cascade do |t|
+    t.string "username"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:44Z

db/schema.rb

  end

+  create_table "users", id: :serial, force: :cascade do |t|


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:44Z

db/schema.rb

-    t.string   "slack_name"
+  create_table "tags", id: :serial, force: :cascade do |t|
+    t.string "name"
+    t.string "external_id"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:44Z

db/schema.rb

-    t.integer  "admin"
-    t.string   "slack_name"
+  create_table "tags", id: :serial, force: :cascade do |t|
+    t.string "name"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:45Z

db/schema.rb

-    t.string   "password_digest"
-    t.integer  "admin"
-    t.string   "slack_name"
+  create_table "tags", id: :serial, force: :cascade do |t|


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:46Z

db/schema.rb

+    t.datetime "image_logo_updated_at"
+    t.string "ref_link"
+    t.text "description"
+    t.integer "is_provider"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:46Z

db/schema.rb

+    t.bigint "image_logo_file_size"
+    t.datetime "image_logo_updated_at"
+    t.string "ref_link"
+    t.text "description"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:47Z

db/schema.rb

+    t.string "image_logo_content_type"
+    t.bigint "image_logo_file_size"
+    t.datetime "image_logo_updated_at"
+    t.string "ref_link"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:47Z

db/schema.rb

+    t.string "image_logo_file_name"
+    t.string "image_logo_content_type"
+    t.bigint "image_logo_file_size"
+    t.datetime "image_logo_updated_at"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2019-05-24T11:48:47Z

db/schema.rb

+    t.binary "image"
+    t.string "image_logo_file_name"
+    t.string "image_logo_content_type"
+    t.bigint "image_logo_file_size"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot

Some files could not be reviewed due to errors:

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml
Warning: unrecognized cop Layout/IndentFirstArrayElement found in .rubocop.yml
Error: Unknown Ruby version 2.6 found in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.1, 2.2, 2.3, 2.4, 2.5

houndci-bot · 2020-01-12T06:03:07Z

app/views/layouts/_sidebar.html.haml

@@ -0,0 +1,31 @@
+#sidebar_content


id attribute must be in lisp-case

houndci-bot · 2020-01-12T06:03:08Z

app/views/layouts/_sidebar.html.haml

+      %i{"data-feather": "pie-chart"}
+      %span Overview
+    = link_to admin_index_path, class: 'item' do
+      %i{"data-feather": "zap"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-01-12T06:03:08Z

app/views/layouts/_sidebar.html.haml

+      %i{"data-feather": "shopping-cart"}
+      %span Manage Today Order
+    = link_to manage_all_days_admin_users_path, class: 'item' do
+      %i{"data-feather": "pie-chart"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-01-12T06:03:08Z

app/views/layouts/_sidebar.html.haml

+      %span Preferences
+  .admin_actions
+    = link_to manage_company_admin_users_path, class: 'item' do
+      %i{"data-feather": "shopping-cart"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-01-12T06:03:09Z

app/views/layouts/_sidebar.html.haml

+      %i{"data-feather": "rotate-ccw"}
+      %span Histories
+    .item
+      %i{"data-feather": "settings"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-01-12T06:03:10Z

app/views/dashboards/_self_order.html.haml

@@ -0,0 +1,39 @@
+#filter_container
+  %h3.ui.header Self Ordering
+  #navbar.ui.borderless.menu


Classes should be listed before IDs (.ui should precede #navbar)

houndci-bot · 2020-01-12T06:03:11Z

app/views/dashboards/_self_order.html.haml

+          /   - @r_tags[res.id.to_s].keys.each do |tag|
+          /     %a.item= tag.name
+  .eleven.wide.column
+    #dishes_container


id attribute must be in lisp-case

houndci-bot · 2020-01-12T06:03:11Z

app/views/dashboards/_self_order.html.haml

@@ -0,0 +1,39 @@
+#filter_container


id attribute must be in lisp-case

houndci-bot · 2020-01-12T06:03:11Z

app/views/dashboards/_self_order.html.haml

+                  %a.name{href: dish_path(dish)}= dish.name
+                  %span.price= show_price dish.price
+                  %button.ui.icon.button.add_button{"data-dish-detail": dish.decorate.detail_as_json}
+                    %i{"data-feather": "plus"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-01-12T06:03:11Z

app/views/dashboards/_self_order.html.haml

+                                options: {class_name: "ui rounded image", img_size: 'thumb'}}
+              .content
+                .header
+                  %a.name{href: dish_path(dish)}= dish.name


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot

Some files could not be reviewed due to errors:

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml
Warning: unrecognized cop Layout/IndentFirstArrayElement found in .rubocop.yml
Error: Unknown Ruby version 2.6 found in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.1, 2.2, 2.3, 2.4, 2.5

houndci-bot · 2020-02-04T16:58:20Z

app/views/layouts/application.html.haml

+%html
+  %head
+    %title EH Canteen
+    = stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': true


Line is too long. [84/80]

houndci-bot · 2020-02-04T16:58:20Z

app/views/layouts/management.haml

+            %i{"data-feather": "coffee"}
+            Restaurant
+          %a.item(href="https://google.com")
+            %i{"data-feather": "users"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T16:58:21Z

app/views/layouts/management.haml

+            %i{"data-feather": "file-text"}
+            Menus
+          = link_to manages_restaurants_path, class: "item #{'active' if controller_name == 'restaurants'}" do
+            %i{"data-feather": "coffee"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T16:58:21Z

app/views/layouts/management.haml

+            %i{"data-feather": "home"}
+            Overview
+          %a.item(href="https://google.com")
+            %i{"data-feather": "file-text"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T16:58:21Z

app/views/layouts/management.haml

+      .ui.borderless.bottom.attached.menu
+        .ui.container
+          = link_to manages_root_path, class: "item p-none--left #{'active' if current_page?(manages_root_path)}" do
+            %i{"data-feather": "home"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T16:58:23Z

app/views/layouts/management.haml

+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}
+    %link{href: "https://employmenthero.com/favicon-96x96.png", rel: "icon", sizes: "96x96", type: "image/png"}/
+    %link{href: "https://fonts.googleapis.com/css?family=Maven+Pro:400,500,700&subset=vietnamese", rel: "stylesheet"}/


Line is too long. [118/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T16:58:23Z

app/views/layouts/management.haml

+    = javascript_include_tag 'new_template', 'data-turbolinks-track': true
+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}
+    %link{href: "https://employmenthero.com/favicon-96x96.png", rel: "icon", sizes: "96x96", type: "image/png"}/


Line is too long. [112/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T16:58:23Z

app/views/layouts/management.haml

+%html
+  %head
+    %title Lunchery | Admin Dashboard
+    = stylesheet_link_tag 'new_template', media: 'all', 'data-turbolinks-track': true


Line is too long. [85/80]

houndci-bot · 2020-02-04T16:58:23Z

app/views/layouts/management.haml

+          = link_to manages_restaurants_path, class: "item #{'active' if controller_name == 'restaurants'}" do
+            %i{"data-feather": "coffee"}
+            Restaurant
+          %a.item(href="https://google.com")


Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))

houndci-bot · 2020-02-04T16:58:23Z

app/views/layouts/management.haml

+          = link_to manages_root_path, class: "item p-none--left #{'active' if current_page?(manages_root_path)}" do
+            %i{"data-feather": "home"}
+            Overview
+          %a.item(href="https://google.com")


Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))

houndci-bot

Some files could not be reviewed due to errors:

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml
Warning: unrecognized cop Layout/IndentFirstArrayElement found in .rubocop.yml
Error: Unknown Ruby version 2.6 found in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.1, 2.2, 2.3, 2.4, 2.5

houndci-bot · 2020-02-04T18:04:05Z

app/views/manages/restaurants/index.haml

+          %input{type:"text",
+                placeholder:"Search restaurant...",
+                class: "appearance-none bg-transparent border-none w-full text-gray-700 mr-3 py-1 px-2 leading-tight focus:outline-none text-lg"}
+      = link_to "Add New Restaurant", new_manages_restaurant_path, class: "ui primary button"


Line is too long. [93/80]

houndci-bot · 2020-02-04T18:04:06Z

app/views/manages/restaurants/index.haml

+          %i.w-8.mr-5.text-gray-500{'data-feather': 'search'}
+          %input{type:"text",
+                placeholder:"Search restaurant...",
+                class: "appearance-none bg-transparent border-none w-full text-gray-700 mr-3 py-1 px-2 leading-tight focus:outline-none text-lg"}


Line is too long. [145/80]

houndci-bot · 2020-02-04T18:04:06Z

app/views/manages/restaurants/index.haml

+      .ui.category.search.item
+        .flex.items-center
+          %i.w-8.mr-5.text-gray-500{'data-feather': 'search'}
+          %input{type:"text",


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T18:04:06Z

app/views/manages/restaurants/index.haml

+    .flex.items-center.justify-between
+      .ui.category.search.item
+        .flex.items-center
+          %i.w-8.mr-5.text-gray-500{'data-feather': 'search'}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T18:04:06Z

app/views/manages/restaurants/index.haml

@@ -0,0 +1,38 @@
+#advanced_table_bundle


id attribute must be in lisp-case

houndci-bot · 2020-02-04T18:04:09Z

app/views/manages/restaurants/new.haml

+    .bg-white.rounded.border-gray-400.p-5
+      %h5.text-lg.font-medium
+        Crawl from
+        %img.inline.h-8(src="https://www.now.vn/app/assets/img/nowvn.png" alt="Now logo")/


Line is too long. [90/80]
Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))

houndci-bot · 2020-02-04T18:04:09Z

app/views/layouts/management.haml

+            %h3 Lunchery
+          .right.menu
+            .item
+              %a.middle-aligned(href="/")


Prefer the hash attributes syntax (%tag{ lang: 'en' }) over HTML attributes syntax (%tag(lang=en))

houndci-bot · 2020-02-04T18:04:10Z

app/views/layouts/dashboard.haml

+    = stylesheet_link_tag 'new_template', media: 'all', 'data-turbolinks-track': true
+    = javascript_include_tag 'new_template', 'data-turbolinks-track': true
+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T18:04:10Z

app/views/layouts/dashboard.haml

+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}
+    %link{href: "https://employmenthero.com/favicon-96x96.png", rel: "icon", sizes: "96x96", type: "image/png"}/
+    %link{href: "https://fonts.googleapis.com/css?family=Maven+Pro:400,500,700&subset=vietnamese", rel: "stylesheet"}/


Line is too long. [118/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T18:04:10Z

app/views/layouts/dashboard.haml

+    = javascript_include_tag 'new_template', 'data-turbolinks-track': true
+    = csrf_meta_tags
+    %script{src: "https://unpkg.com/feather-icons"}
+    %link{href: "https://employmenthero.com/favicon-96x96.png", rel: "icon", sizes: "96x96", type: "image/png"}/


Line is too long. [112/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot

Some files could not be reviewed due to errors:

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml
Warning: unrecognized cop Layout/IndentFirstArrayElement found in .rubocop.yml
Error: Unknown Ruby version 2.6 found in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.1, 2.2, 2.3, 2.4, 2.5

houndci-bot · 2020-02-04T19:05:03Z

app/views/dashboards/_self_order.html.haml

+    %a.item(href="?select_date=#{@select_date - 1.day}")
+      %i{"data-feather": "chevron-left"}
+    %a.item(href="?select_date=#{@select_date + 1.day}")
+      %i{"data-feather": "chevron-right"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T19:05:03Z

app/views/dashboards/_self_order.html.haml

+  %h3.ui.header Self Ordering
+  #navbar.ui.borderless.menu
+    %a.item(href="?select_date=#{@select_date - 1.day}")
+      %i{"data-feather": "chevron-left"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T19:05:04Z

app/views/dashboards/_self_order.html.haml

+      %i{"data-feather": "chevron-left"}
+    %a.item(href="?select_date=#{@select_date + 1.day}")
+      %i{"data-feather": "chevron-right"}
+    .item= @select_date.strftime("%A, %B %e, %Y")


Avoid using instance variables in partials views

houndci-bot · 2020-02-04T19:05:04Z

app/views/dashboards/_self_order.html.haml

+                .header
+                  %a.name{href: dish_path(dish)}= dish.name
+                  %span.price= show_price dish.price
+                  %button.ui.icon.button.add_button{"data-dish-detail": dish.decorate.detail_as_json}


Line is too long. [101/80]
Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T19:05:05Z

app/views/dashboards/_self_order.html.haml

+                                restaurant: dish,
+                                size: [120, 120],
+                                object: 'dish',
+                                options: {class_name: "ui rounded image", img_size: 'thumb'}}


Line is too long. [93/80]

houndci-bot · 2020-02-04T19:05:07Z

app/views/layouts/_header.html.haml

+          %li= link_to "Home", order_user_path(current_user)
+          %li= link_to "How to use", help_path
+          %li.dropdown
+            %a.dropdown-toggle{"data-toggle" => "dropdown", :href => "#"}


Hash attribute should start with one space after the opening brace
Hash attribute should end with one space before the closing brace

houndci-bot · 2020-02-04T19:05:07Z

app/views/layouts/_header.html.haml

+              - if is_admin?
+                %li= link_to "Manager Page", manage_admin_users_path
+                %li.divider
+                %li= link_to "PING SLACK", ping_slack_admin_users_path, data: {confirm: 'This ping can cause noise for users. Do you want to continue?'}


Line is too long. [152/80]

houndci-bot · 2020-02-04T19:05:07Z

app/views/dashboards/index.html.haml

+          #indicatorContainer
+          %p.average Avg 78.000 / 80.000 đ
+      #order_cart.ui.segment
+        %table#dishes.ui.very.basic.celled.table


Classes should be listed before IDs (.ui should precede #dishes)

houndci-bot · 2020-02-04T19:05:08Z

app/views/dashboards/index.html.haml

+          %h3.ui.header Monthly budget:
+          #indicatorContainer
+          %p.average Avg 78.000 / 80.000 đ
+      #order_cart.ui.segment


id attribute must be in lisp-case
Classes should be listed before IDs (.ui should precede #order_cart)

houndci-bot · 2020-02-04T19:05:08Z

app/views/dashboards/index.html.haml

+      #summary_panel.ui.segment
+        .content
+          %h3.ui.header Monthly budget:
+          #indicatorContainer


id attribute must be in lisp-case

houndci-bot

Some files could not be reviewed due to errors:

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml

Warning: unrecognized cop Layout/IndentFirstHashElement found in .rubocop.yml
Warning: unrecognized cop Layout/IndentFirstArrayElement found in .rubocop.yml
Error: Unknown Ruby version 2.6 found in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.1, 2.2, 2.3, 2.4, 2.5

houndci-bot · 2020-02-07T14:19:15Z

app/views/dashboards/index.html.haml

+
+      $.post("#{create_order_dashboards_path}", dish_params, function(response_data) {
+        $("#order_cart .empty-order").hide();
+        selectedOrderItemHtml = HandlebarsTemplates['selected_order_item'](dish_detail);


Line is too long. [88/80]

houndci-bot · 2020-02-07T14:19:15Z

app/views/dashboards/index.html.haml

+        select_date: "#{@select_date}"
+      }
+
+      $.post("#{create_order_dashboards_path}", dish_params, function(response_data) {


Line is too long. [86/80]

houndci-bot · 2020-02-07T14:19:16Z

app/views/dashboards/index.html.haml

+                                          restaurant: dish,
+                                          size: [120, 120],
+                                          object: 'dish',
+                                          options: {class_name: "ui rounded image", img_size: 'thumb'}}


Line is too long. [103/80]

houndci-bot · 2020-02-07T14:19:16Z

app/views/dashboards/index.html.haml

+      -# = render "dashboards/aggregate"
+      = render "dashboards/self_order"
+    .five.wide.column
+      #summary_panel.ui.segment


Classes should be listed before IDs (.ui should precede #summary_panel)
id attribute must be in lisp-case

houndci-bot · 2020-02-07T14:19:16Z

app/views/layouts/management.haml

+              .ui.basic.button Sign Out
+      .ui.borderless.bottom.attached.menu
+        .ui.container
+          = link_to manages_root_path, class: "item #{'active' if current_page?(manages_root_path)}" do


Line is too long. [103/80]

houndci-bot · 2020-02-07T14:19:19Z

app/assets/stylesheets/spacing.scss

+      }
+      &--left, &--sides {
+        #{$value}-left: $size $ip;
+      }


Rule declaration should be followed by an empty line

houndci-bot · 2020-02-07T14:19:19Z

app/assets/stylesheets/spacing.scss

+      &--bottom, &--ends {
+        #{$value}-bottom: $size $ip;
+      }
+      &--left, &--sides {


Each selector in a comma sequence should be on its own single line

houndci-bot · 2020-02-07T14:19:19Z

app/assets/stylesheets/spacing.scss

+      }
+      &--bottom, &--ends {
+        #{$value}-bottom: $size $ip;
+      }


Rule declaration should be followed by an empty line

houndci-bot · 2020-02-07T14:19:19Z

app/assets/stylesheets/spacing.scss

+      &--top, &--ends {
+        #{$value}-top: $size $ip;
+      }
+      &--bottom, &--ends {


Each selector in a comma sequence should be on its own single line

houndci-bot · 2020-02-07T14:19:20Z

app/assets/stylesheets/spacing.scss

+      }
+      &--top, &--ends {
+        #{$value}-top: $size $ip;
+      }


Rule declaration should be followed by an empty line

nv-anhvy added 7 commits April 24, 2019 16:19

Upgraded rails

7066d10

Updated new UI for login page

9f6a618

Converted layout to haml

3874392

A few fixes

1d91e6a

Added sidebar template

4332565

[WIP] Updating UI for legacy order

55672b7

Wrapped new layout

65d8af2

houndci-bot reviewed May 14, 2019

View reviewed changes

vutienduongeh added the WIP Work in progress label May 14, 2019

vutienduongeh changed the title ~~Update new UI~~ [WIP] Update new UI May 14, 2019

nv-anhvy added 2 commits May 20, 2019 15:32

Few ignorance

44c8c9b

Finished UI for current order

942b069

houndci-bot reviewed May 20, 2019

View reviewed changes

Added create order actions

1f71385

houndci-bot reviewed May 20, 2019

View reviewed changes

nv-anhvy added 2 commits May 20, 2019 19:38

Added create order actions

d57a479

Merge development

c037f21

houndci-bot reviewed May 24, 2019

View reviewed changes

nv-anhvy added 7 commits June 1, 2019 02:40

Ignored .env

bb1fecc

Disabled capybara-webkit temporary

e0eca0c

Added back rubocop config

c5e0b09

Update rubocop

e68d242

Working on new dashboard UI

f6cc92b

Working on refine layout

2fd3362

[WIP]

1bb074d

houndci-bot reviewed Jan 12, 2020

View reviewed changes

feat: new admin layout

bd31cf4

houndci-bot reviewed Feb 4, 2020

View reviewed changes

chore: update bundler version

5f862f4

houndci-bot reviewed Feb 4, 2020

View reviewed changes

nv-anhvy added 3 commits February 5, 2020 01:07

chore: temporary change background color

9216c05

chore: use latest bundler

4b476d3

chore: upgrade to latest ruby version

e21a083

houndci-bot reviewed Feb 4, 2020

View reviewed changes

nv-anhvy added 2 commits February 7, 2020 21:00

chore: restyle login page

1de4dca

chore: enhance UI with simplebar

f985d15

houndci-bot reviewed Feb 7, 2020

View reviewed changes

		@@ -1,4 +1,4 @@
		class AddExternalIdToTag < ActiveRecord::Migration
		class AddExternalIdToTag < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class AddCustomizableToOrder < ActiveRecord::Migration
		class AddCustomizableToOrder < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class CreateDishRestaurantAssociation < ActiveRecord::Migration
		class CreateDishRestaurantAssociation < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class AddExternalIdToRestaurant < ActiveRecord::Migration
		class AddExternalIdToRestaurant < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class AddExternalIdToDish < ActiveRecord::Migration
		class AddExternalIdToDish < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class PersonalSetting < ActiveRecord::Migration
		class PersonalSetting < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class CreateGeneralSetting < ActiveRecord::Migration
		class CreateGeneralSetting < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class CreateMenuHistory < ActiveRecord::Migration
		class CreateMenuHistory < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class CreateProviderDishMappingTable < ActiveRecord::Migration
		class CreateProviderDishMappingTable < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class CreateDailyRestaurant < ActiveRecord::Migration
		class CreateDailyRestaurant < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class AddColumnIsProviderToRestaurant < ActiveRecord::Migration
		class AddColumnIsProviderToRestaurant < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class AddAuthorToNotice < ActiveRecord::Migration
		class AddAuthorToNotice < ActiveRecord::Migration[4.2]

		@@ -1,4 +1,4 @@
		class CreateNotices < ActiveRecord::Migration
		class CreateNotices < ActiveRecord::Migration[4.2]

		end

		create_table "users", id: :serial, force: :cascade do \|t\|

[WIP] Update new UI #13

Are you sure you want to change the base?

[WIP] Update new UI #13

Conversation

vutienduongeh commented May 14, 2019

vutienduongeh commented May 14, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment