Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fastText to latest upstream master #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dcsan
Copy link

@dcsan dcsan commented Aug 23, 2018

simply updated to their master
https://github.com/facebookresearch/fastText/commits/master

process:

(clone this repo)

git submodule init
git pull --recurse-submodules
cd fastText
git checkout master
git pull
cd ..
git add .
git commit -m "update submodules"

I might make a script to do this if we need to keep track of upstream fastText

@vunb vunb self-requested a review August 24, 2018 15:29
Copy link
Owner

@vunb vunb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Upgrade to use new fastText api(s)
  • Adjust and update node-fasttext codebase

@searleser97
Copy link

does this update will ever reach master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants