fix(memmetrics): prevent 'now' from accumulating during cleanup #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
ldez
changed the title
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I try to use circuit breaker and set the checkPeriod greater than 10 seconds.
My expectation was that the count would only reflect the values from the most recent 10 seconds.
However, the results didn't match my expectations.
I found that in the RollingCounter's cleanup method, the value of now appears to accumulate.
When lastUpdated is not the latest (e.g., from several seconds ago), it seems to result in some slots not being properly cleaned up.
I've proposed a fix in this pull request, and I'd appreciate it if you could review it.
Thank you for your time!
Best regards,
Mike