Upgrade Phing to version 3.0 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extra slash
Replace phpunit_command with sh
demiankatz
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Thanks, @sturkel89 -- since I know you have a meeting now, I made a couple of trivial edits in order to be able to merge this now:
1.) I adjusted the whitespace in composer.json to elminate some extra spaces (which makes the diffs easier to read).
2.) I removed the "downloadsdir" property -- I'm not sure where that came from, but it was added here and not actually used for anything. Probably an artifact of some feature of a different build.xml that isn't replicated in this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the two files.