fix: function-based configuration when using extend in the sdk (#7331)

vuestorefront · Nov 26, 2024 · 7a7e950 · 7a7e950
1 parent 8fd8426
commit 7a7e950
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/empty-cycles-lay.md b/.changeset/empty-cycles-lay.md
@@ -0,0 +1,5 @@
+---
+"@vue-storefront/sdk": patch
+---
+
+- **[FIX]** Fixed type inference for function-based configurations when using the [extend](https://docs.alokai.com/sdk/advanced/extending-module#extend) method. Now the `methods` object is correctly typed.
diff --git a/packages/sdk/src/modules/buildModule.ts b/packages/sdk/src/modules/buildModule.ts
@@ -74,7 +74,7 @@ function buildModule<
 
   const resolvedExtension =
     typeof extension === "function"
-      ? extension(extensionOptions, {
+      ? extension(extensionOptions ?? ({} as ExtensionOptions), {
           methods: resolvedModule.connector,
           context: resolvedModule?.context ?? {},
         })

diff --git a/packages/sdk/src/types/index.ts b/packages/sdk/src/types/index.ts
@@ -279,10 +279,10 @@ export type ExtensionInitializer<
   InitializedExtension extends Extension<ExtendedModule>,
   Options extends ModuleOptions
 > = (
-  options?: Options,
-  parent?: {
+  options: Options,
+  parent: {
     methods: ExtendedModule["connector"];
-    context?: ExtendedModule["context"];
+    context: ExtendedModule["context"];
   }
 ) => InitializedExtension;