Skip to content

Commit

Permalink
Merge pull request #181 from vtex-apps/fix/login-button-redirecting
Browse files Browse the repository at this point in the history
Fix login button redirection issue
  • Loading branch information
diegoleone authored Sep 26, 2024
2 parents 22a957d + a00e79b commit 9bf11ef
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Fix

- change redirection method of the login button click event

## [1.18.3] - 2024-09-17

### Fix
Expand Down
6 changes: 2 additions & 4 deletions react/AddProductBtn.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,13 +171,11 @@ const AddBtn: FC<AddBtnProps> = ({ toastURL = '/account/#wishlist' }) => {
action = {
label: intl.formatMessage(messages.login),
onClick: () =>
navigate({
page: 'store.login',
query: `returnUrl=${encodeURIComponent(
window.location.assign(`/login?returnUrl=${encodeURIComponent(

Check failure on line 174 in react/AddProductBtn.tsx

View workflow job for this annotation

GitHub Actions / QE / Lint Node.js

Insert `⏎············`
String(history?.location?.pathname) +
String(history?.location?.search)
)}`,

Check failure on line 177 in react/AddProductBtn.tsx

View workflow job for this annotation

GitHub Actions / QE / Lint Node.js

Delete `,`
}),
),
}
}
if (messsageKey === 'productAddedToList') {
Expand Down

0 comments on commit 9bf11ef

Please sign in to comment.