Fix/show more 25 options at organizations auto complete #30
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
| @@ -11,7 +11,7 @@ const initialState = { | |||
| status: ['active', 'on-hold', 'inactive'], | |||
| search: '', | |||
| page: 1, | |||
| pageSize: 25, | |||
| pageSize: 999, | |||
There was a problem hiding this comment.
Instead of setting the page size to 999, can't we handle the pagination? Also, have we tested this with 999 cost centers to check the behaviour?
There was a problem hiding this comment.
decrease the page size to 500
| @@ -78,7 +78,7 @@ const OrganizationsAutocomplete = ({ onChange, organizationId }: Props) => { | |||
| }, [data]) | |||
|
|
|||
| useEffect(() => { | |||
| if (term && term.length > 2) { | |||
| if (term && term.length > 0) { | |||
There was a problem hiding this comment.
Qual o objetivo dessa mudança?
There was a problem hiding this comment.
A mudança foi feita para garantir que o useEffect seja disparado sempre que o termo de busca não estiver vazio. Anteriormente, o efeito só era executado quando o termo tinha mais de dois caracteres, o que poderia deixar de capturar casos onde termos menores são relevantes. @ataideverton
There was a problem hiding this comment.
Ao permitir que o efeito seja disparado com a primeira entrada, garantimos que o feedback ao usuário seja mais responsivo, evitando a sensação de que a aplicação está ignorando entradas válidas
Co-authored-by: Enzo Mercanti <[email protected]>
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Before, it was not possible to show more than 25 options at the dropdown organization
This change might be motivated by experience from user, enabling a better visualization of organizations
How to test it?
In the admin panel, follow these navigation steps:
Workspace
Screenshots or example usage:
Describe alternatives you've considered, if any.
Related to / Depends on
How does this PR make you feel? 🔗
![](put .gif link here - can be found under "advanced" on giphy)